How to build C++ tests?

[D8H]

Related discussion with Linux:

• String autocompletion in expressions for scene names, layer names and choices #2702 (comment)

Context

I tried to build C++ tests.

• Windows - 10.0.19041
• MinGW-w64 10.2.0
• Ninja 1.10.2
• commit d9172de (the one before my commit)
• With this change suggested by Arthuro for a previous error

diff --git a/GDCpp/GDCpp/Events/CodeGeneration/EventsCodeGenerator.cpp

using namespace std;
+
+#undef GetObject

gd::String EventsCodeGenerator::GenerateObjectFunctionCall(

• Running
  • cmake .. -DBUILD_GDJS=FALSE -DBUILD_TESTS=TRUE -G "Ninja"
  • ninja

Errors

• Ninja stopped here

[443/760] Linking CXX shared library ..\Binaries\Output\Release_Windows\GDCpp.dll
FAILED: ../Binaries/Output/Release_Windows/GDCpp.dll ../Binaries/Output/Release_Windows/libGDCpp.dll.a
cmd.exe /C "cd . && C:\ProgramData\chocolatey\bin\c++.exe -std=gnu++11 -O3 -DNDEBUG   -shared -o ..\Binaries\Output\Release_Windows\GDCpp.dll -Wl,--out-implib,..\Binaries\Output\Release_Windows\libGDCpp.dll.a -Wl,--major-image-version,0,--minor-image-version,0 @CMakeFiles\GDCpp.rsp  && cd ."
c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: GDCpp/CMakeFiles/GDCpp.dir/GDCpp/Runtime/RuntimeBehavior.cpp.obj:RuntimeBehavior.cpp:(.text+0x3): undefined reference to `__imp__ZTV15RuntimeBehavior'
c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: GDCpp/CMakeFiles/GDCpp.dir/GDCpp/Runtime/RuntimeBehavior.cpp.obj:RuntimeBehavior.cpp:(.text+0x39): undefined reference to `__imp__ZTV15RuntimeBehavior'
c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: GDCpp/CMakeFiles/GDCpp.dir/GDCpp/Runtime/RuntimeBehavior.cpp.obj:RuntimeBehavior.cpp:(.text$_ZNK15RuntimeBehavior5CloneEv[_ZNK15RuntimeBehavior5CloneEv]+0x76): undefined reference to `__imp__ZTV15RuntimeBehavior'
c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: GDCpp/CMakeFiles/GDCpp.dir/GDCpp/Runtime/RuntimeObject.cpp.obj:RuntimeObject.cpp:(.text+0xd718): undefined reference to `__imp__ZTV15RuntimeBehavior'
c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: GDCpp/CMakeFiles/GDCpp.dir/GDCpp/Runtime/RuntimeObject.cpp.obj:RuntimeObject.cpp:(.text+0xd7d9): undefined reference to `__imp__ZTV15RuntimeBehavior'
collect2.exe: error: ld returned 1 exit status
[448/760] Building CXX object Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionParser2.cpp.obj
ninja: build stopped: subcommand failed.

• The whole logs and useful files: ConsoleOutput.zip

Questions

• Do you you know why I've got this failure?
• With which environment did you succeed to build C++ tests?

[4ian]

Can you try to compile just GDCore_tests target? ninja GDCore_tests (and then you can run the test executable output in Core/GDCore_tests in the build folder).

[D8H]

It fails at the linking. I think this is the message: undefined reference to 'gd::ExpressionParserDiagnostic::noMessage'

[270/270] Linking CXX executable Core\GDCore_tests.exe
FAILED: Core/GDCore_tests.exe
cmd.exe /C "cd . && C:\ProgramData\chocolatey\bin\c++.exe -std=gnu++11 -O3 -DNDEBUG  Core/CMakeFiles/GDCore_tests.dir/tests/AbstractFileSystem.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/Common.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/DependenciesAnalyzer.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/DummyPlatform.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/Events.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/EventsCodeGenerationContext.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/EventsCodeGenerator.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/EventsFunctionsContainer.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/EventsFunctionsExtension.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionCodeGenerator.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionCompletionFinder.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionNodeLocationFinder.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionParser2.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionParser2Benchmarks.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionParser2NaugtyStrings.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionParser2NodePrinter.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/FileStream.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/InitialInstance.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/InitialInstancesContainer.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/NewNameGenerator.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/Resources.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/ResourcesMergingHelper.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/ResourcesRenamer.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/SceneNameMangler.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/Serializer.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/SourceFiles.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/Utf8Tests.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/Variable.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/VariablesContainer.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/WholeProjectRefactorer.cpp.obj Core/CMakeFiles/GDCore_tests.dir/tests/main.cpp.obj -o Core\GDCore_tests.exe -Wl,--out-implib,Core\libGDCore_tests.dll.a -Wl,--major-image-version,0,--minor-image-version,0  ../Binaries/Output/Release_Windows/libGDCore.dll.a  ExtLibs/SFML/lib/libsfml-audio.a  ExtLibs/SFML/lib/libsfml-graphics.a  ExtLibs/SFML/lib/libsfml-window.a  ExtLibs/SFML/lib/libsfml-network.a  ExtLibs/SFML/lib/libsfml-system.a  -lws2_32  -luser32  -lopengl32  -lglu32  -lpsapi  ../ExtLibs/SFML/extlibs/libs-mingw/x64/libopenal32.a  ../ExtLibs/SFML/extlibs/libs-mingw/x64/libvorbisenc.a  ../ExtLibs/SFML/extlibs/libs-mingw/x64/libvorbisfile.a  ../ExtLibs/SFML/extlibs/libs-mingw/x64/libvorbis.a  ../ExtLibs/SFML/extlibs/libs-mingw/x64/libogg.a  ../ExtLibs/SFML/extlibs/libs-mingw/x64/libFLAC.a  ../ExtLibs/SFML/extlibs/libs-mingw/x64/libfreetype.a  ../ExtLibs/SFML/extlibs/libs-mingw/x64/libjpeg.a  -lgdi32  -lwinmm  -lopengl32  -lkernel32 -luser32 -lgdi32 -lwinspool -lshell32 -lole32 -loleaut32 -luuid -lcomdlg32 -ladvapi32 && cd ."
c:/programdata/chocolatey/lib/mingw/tools/install/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionCodeGenerator.cpp.obj:ExpressionCodeGenerator.cpp:(.rdata$.refptr._ZN2gd26ExpressionParserDiagnostic9noMessageE[.refptr._ZN2gd26ExpressionParserDiagnostic9noMessageE]+0x0): undefined reference to `gd::ExpressionParserDiagnostic::noMessage'
collect2.exe: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

[D8H]

I dug a bit.

I can build without error if I remove these tests

• Core/tests/ExpressionCodeGenerator.cpp
• Core/tests/ExpressionCompletionFinder.cpp
• Core/tests/ExpressionNodeLocationFinder.cpp
• Core/tests/ExpressionParser2.cpp
• Core/tests/ExpressionParser2Benchmarks.cpp
• Core/tests/ExpressionParser2NaugtyStrings.cpp
• Core/tests/ExpressionParser2NodePrinter.cpp

Because they use ExpressionParser2Node and ExpressionCompletionFinder. The linking fails on the content of the cpp, it seems

• undefined reference to `gd::ExpressionParserDiagnostic::noMessage'
• undefined reference to `gd::ExpressionCompletionDescription::badParameterMetadata'
• undefined reference to `gd::operator<<(std::ostream&, gd::ExpressionCompletionDescription const&)'

GDevelop/Core/GDCore/Events/Parsers/ExpressionParser2Node.cpp

Lines 6 to 10 in b97f716

	#include "ExpressionParser2Node.h"
	namespace gd {
	gd::String ExpressionParserDiagnostic::noMessage = "";
	}

GDevelop/Core/GDCore/IDE/Events/ExpressionCompletionFinder.cpp

Lines 6 to 31 in b97f716

	#include "ExpressionCompletionFinder.h"
	namespace gd {
	const gd::ParameterMetadata
	ExpressionCompletionDescription::badParameterMetadata;
	/**
	* \brief Turn an ExpressionCompletionDescription to a string.
	*/
	std::ostream& operator<<(std::ostream& os,
	ExpressionCompletionDescription const& value) {
	os << "{ " << value.GetCompletionKind() << ", " << value.GetType() << ", "
	<< value.GetPrefix() << ", " << value.GetObjectName() << ", "
	<< value.GetBehaviorName() << ", "
	<< (value.IsExact() ? "exact" : "non-exact") << ", "
	<< (value.IsLastParameter() ? "last parameter" : "not last parameter")
	<< ", "
	<< (value.HasParameterMetadata()
	? gd::String::From(&value.GetParameterMetadata())
	: "no parameter metadata")
	<< " }";
	return os;
	}
	} // namespace gd

Full error messages

mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionCodeGenerator.cpp.obj:ExpressionCodeGenerator.cpp:(.rdata$.refptr._ZN2gd26ExpressionParserDiagnostic9noMessageE[.refptr._ZN2gd26ExpressionParserDiagnostic9noMessageE]+0x0): undefined reference to `gd::ExpressionParserDiagnostic::noMessage'
mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionCompletionFinder.cpp.obj:ExpressionCompletionFinder.cpp:(.text$_ZN5Catch6Detail13rangeToStringIN9__gnu_cxx17__normal_iteratorIPKN2gd31ExpressionCompletionDescriptionESt6vectorIS5_SaIS5_EEEEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEET_SI_[_ZN5Catch6Detail13rangeToStringIN9__gnu_cxx17__normal_iteratorIPKN2gd31ExpressionCompletionDescriptionESt6vectorIS5_SaIS5_EEEEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEET_SI_]+0x3aa): undefined reference to `gd::operator<<(std::ostream&, gd::ExpressionCompletionDescription const&)'
mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionCompletionFinder.cpp.obj:ExpressionCompletionFinder.cpp:(.text$_ZN5Catch6Detail13rangeToStringIN9__gnu_cxx17__normal_iteratorIPKN2gd31ExpressionCompletionDescriptionESt6vectorIS5_SaIS5_EEEEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEET_SI_[_ZN5Catch6Detail13rangeToStringIN9__gnu_cxx17__normal_iteratorIPKN2gd31ExpressionCompletionDescriptionESt6vectorIS5_SaIS5_EEEEEENSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEET_SI_]+0x6af): undefined reference to `gd::operator<<(std::ostream&, gd::ExpressionCompletionDescription const&)'
mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.2.0/../../../../x86_64-w64-mingw32/bin/ld.exe: Core/CMakeFiles/GDCore_tests.dir/tests/ExpressionCompletionFinder.cpp.obj:ExpressionCompletionFinder.cpp:(.rdata$.refptr._ZN2gd31ExpressionCompletionDescription20badParameterMetadataE[.refptr._ZN2gd31ExpressionCompletionDescription20badParameterMetadataE]+0x0): undefined reference to `gd::ExpressionCompletionDescription::badParameterMetadata'
collect2.exe: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

[4ian]

Very weird, it's like these two cpp files were not compiled, or not exported.

• Can you check they are (type a mistake in one, try to recompile).
• Can you add GD_API after the "struct" of ExpressionCompletionDescription? (=> struct GD_API ExpressionCompletionDescription ) and same for ExpressionParserDiagnostic?

[D8H]

* Can you check they are (type a mistake in one, try to recompile).

I added a syntax error. It's detected.

FAILED: Core/CMakeFiles/GDCore.dir/GDCore/Events/Parsers/ExpressionParser2Node.cpp.obj
C:\ProgramData\chocolatey\bin\c++.exe -DGDCore_EXPORTS -DGD_CORE_API=__declspec(dllexport) -DGD_IDE_ONLY -DRELEASE -DWINDOWS -D__GNUWIN32__ -I../ExtLibs/SFML/include -I../Core/. -std=gnu++11 -O3 -DNDEBUG -MD -MT Core/CMakeFiles/GDCore.dir/GDCore/Events/Parsers/ExpressionParser2Node.cpp.obj -MF Core\CMakeFiles\GDCore.dir\GDCore\Events\Parsers\ExpressionParser2Node.cpp.obj.d -o Core/CMakeFiles/GDCore.dir/GDCore/Events/Parsers/ExpressionParser2Node.cpp.obj -c ../Core/GDCore/Events/Parsers/ExpressionParser2Node.cpp
../Core/GDCore/Events/Parsers/ExpressionParser2Node.cpp:11:1: error: expected unqualified-id before '{' token
   11 | {{
      | ^
../Core/GDCore/Events/Parsers/ExpressionParser2Node.cpp:12:1: error: expected '}' at end of input
   12 | }
      | ^
../Core/GDCore/Events/Parsers/ExpressionParser2Node.cpp:8:14: note: to match this '{'
    8 | namespace gd {
      |              ^
[35/340] Building CXX object Core/CMakeFiles/GDCore.dir/GDCore/Events/CodeGeneration/EventsCodeGenerator.cpp.obj
ninja: build stopped: subcommand failed.

Can you add GD_API after the "struct" of ExpressionCompletionDescription? (=> struct GD_API ExpressionCompletionDescription ) and same for ExpressionParserDiagnostic?

When I add them (after reverting the syntax error), it seems to break the source and no definition is done.
Random instances of the many errors (more than my console buffer can show):

'size_t ExpressionParserError::GetEndPosition()' marked 'override', but does not override
'location' was not declared in this scope; did you mean 'localtime'?
'ExpressionParserDiagnostic' was not declared in this scope; did you mean 'gd::ExpressionParserDiagnostic'?
request for member 'OnVisitNumberNode' in 'worker', which is of non-class type 'int'

[D8H]

When I run GDCore_tests.exe is says it misses GDCore.dll.
I think it should be produced next to the exe when ninja is run but it says there is no work to do.

Is there something to add to the path to run the tests?