karma test command doesn't work in windows

[HarsimranVirk]

GDevelop/GDJS/tests/package.json

Lines 8 to 9 in 661d329

	"test": "./node_modules/karma/bin/karma start --browsers ChromeHeadless --single-run",
	"test:firefox": "./node_modules/karma/bin/karma start --browsers Firefox --single-run"

These don't work on windows because ./something/app results in '.' is not recognized as an internal or external command, operable program or batch file. due to differences of backslash/frontslash.

Maybe a more inclusive command could be "test": "cd ./node_modules/karma/bin && karma start ../../../karma.conf.js --browsers ChromeHeadless --single-run" (and similar for firefox) as this should work in all environments 😅

[arthuro555]

I always jusr manually run karma like this if I remember correctly: .\node_modules\.bin\karma.cmd start --browsers ChromeHeadless --single-run

[HarsimranVirk]

@arthuro555 .\something\app works fine as cmd understands .\ but not ./ due to differences between frontslash and backslash 😅. This is why it's better to change directory (as both windows and linux/macOS would interpret them correctly) and then run karma, and because we are in a different dir, specify the correct path to karma.conf.js (which is ../../../karma.conf.js in this case).

[arthuro555]

We shouldn’t use a backslash at all, if karma is in node_modules/.bin, we should call karma directly and it should call the version installed in node_modules automatically De : Harsimran Singh Virk<mailto:notifications@github.com> Envoyé le :mercredi 22 juillet 2020 18:59 À : 4ian/GDevelop<mailto:GDevelop@noreply.github.com> Cc : Arthur Pacaud<mailto:arthur.pacaud@hotmail.fr>; Mention<mailto:mention@noreply.github.com> Objet :Re: [4ian/GDevelop] karma test command doesn't work in windows (#1883) @arthuro555<https://github.com/arthuro555> .\something\app works fine as cmd understands .\ but not ./ due to differences between frontslash and backslash 😅. This is why it's better to change directory (as both windows and linux/macOS would interpret them correctly) and then run karma, and because we are in a different dir, specify the correct path to karma.conf.js (which is ../../../karma.conf.js in this case). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1883 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AETT4LV5NA4OZCALEA3DQTTR44LGVANCNFSM4PCKIDRA>.

[HarsimranVirk]

if karma is in node_modules/.bin, we should call karma directly and it should call the version installed in node_modules automatically

Yes, this could be the most correct way I'd say then 👍