Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension name collision in the extension list. #5104

Closed
Bouh opened this issue Mar 13, 2023 · 7 comments
Closed

Extension name collision in the extension list. #5104

Bouh opened this issue Mar 13, 2023 · 7 comments

Comments

@Bouh
Copy link
Collaborator

Bouh commented Mar 13, 2023

Describe the bug

If you name your own local extension the same name as an actual official extension of the Catalog, it will be shown as “Already installed”

To Reproduce

Steps to reproduce the behavior:

  1. Create a new Extension
  2. Rename it “Bounce”
  3. Check the official extensions Catalog
  4. Notice than the “Bounce” extension from 4ian is labelled “Already installed”

Other details

Source on the forum

@infokub
Copy link
Contributor

infokub commented Mar 13, 2023

I had a look at it, What could be the desired behaviour here ?
I found the method checking it, but i don't know what i can change to correct that x)

EDIT:
For the extensions coming from the Catalog, there is a "origin" tag set in the descriptor, i'll follow that way.

@D8H
Copy link
Collaborator

D8H commented Mar 13, 2023

The UI could check the extension origin to improve the message, but I guess what is the most important is that it does warn that the existing extension will be erased.

@4ian
Copy link
Owner

4ian commented Mar 13, 2023

We could probably rename the tag so that it shows "Not installed - but a different extension with this name is" (or something like this).
If the user really wants to install it, they will be warned it will be overwritten, which is I think fine.

@infokub
Copy link
Contributor

infokub commented Mar 14, 2023

Yep after working on it i also thought about changing the tag "Already installed" by "Conflict found" and the Install button displaying a warning. So we kinda all agree.
Wish me luck for my first complete compilation 🤞

infokub added a commit to infokub/GDevelop that referenced this issue Mar 15, 2023
infokub added a commit to infokub/GDevelop that referenced this issue Mar 15, 2023
infokub added a commit to infokub/GDevelop that referenced this issue Mar 18, 2023
infokub added a commit to infokub/GDevelop that referenced this issue Mar 18, 2023
@AlexandreSi
Copy link
Collaborator

If you need help, do not hesitate to submit a PR and ask questions in the conversation

@infokub
Copy link
Contributor

infokub commented Mar 28, 2023

hey @AlexandreSi thanks for help, the PR is already merged:
#5111 (comment)

@AlexandreSi
Copy link
Collaborator

Perfect! I'm closing this issue then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants