Add missing translation tags #2953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ian
reviewed
Aug 20, 2021
| ? 'Common expressions for all objects' | ||
| : extension.getFullName()) + GROUP_DELIMITER | ||
| return extension.getName() === 'BuiltinObject' ? ( | ||
| <Trans>Common expressions for all objects</Trans> |
There was a problem hiding this comment.
This fix is more complex, it will involve either passing the translated string as an argument, or passing down the translation function+macro, as you're supposed to return a string, not a React Node.
4ian
approved these changes
Aug 20, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix these reports #969 (comment)
Think to bundle the new translations files from Crowdin in the next build. Translations have not been updated for the latest versions.