[Platformer] Add a frame rate independent movement mode. #3417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So cool! I'll check that tomorrow :) |
4ian
reviewed
Jan 2, 2022
| behavior._requestedDeltaY -= previousJumpSpeed * timeDelta; | ||
|
|
||
| // Fall | ||
| // This is arbitrary. It used to not be obvious. |
There was a problem hiding this comment.
I'm not sure I understand this comment?
| // Here, if we had pressed Right the character would have been falling. | ||
| runtimeScene.renderAndStep(1000 / 60); | ||
| expect(object.getBehavior('auto1').isOnLadder()).to.be(true); | ||
| // Now, it fells. |
There was a problem hiding this comment.
Suggested change
| // Now, it fells. | |
| // Now, it falls. |
4ian
reviewed
Jan 2, 2022
| // The condition is a legacy thing. | ||
| // There is no actual reason not to fall at 1st frame. | ||
| // Before a refactoring, it used to not be this obvious. | ||
| if (!this._jumpingFirstDelta) { |
There was a problem hiding this comment.
I indeed can't remember why I added this 🤔
4ian
approved these changes
Jan 2, 2022
|
Thank you for working on this! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a Verlet integration.
It also fix the ledge grabbing: when the character is on exactly on right Y, it can now grab.
It add tests to check that the trajectory is the same on different frame rate for jump/fall and walking.
The existing tests have been adapted to this new mode. Only the basic jump test uses the legacy mode. I think it allows to check that the legacy mode works without having to maintain 2 test suites. But, if you want to reduce regression risk during the transition, I can add the old suite in a legacy folder.
I sometimes made tests less constraint. This is to only check what is really matter for the test to help readability and make them easier to maintain.