-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Steamworks Support #5401
Add Steamworks Support #5401
Conversation
Testing build download URL: https://s3.arthuro555.com/GDevelop_Steamworks.exe |
Fixed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall!
Co-authored-by: Florian Rival <Florian.rival@gmail.com>
Note to anyone that used the test build above: some internal condition names have changed, and thus will not be recognized by GDevelop once the feature releases, you will have to re-add those conditions! |
(This is ready for another review/merging, by the way) |
This makes the macOS code signing to fail: see https://app.circleci.com/pipelines/github/4ian/GDevelop/10204/workflows/facc11a8-54f2-4de7-9af0-b61df63f63a6/jobs/11290
I read "because larger updated load commands do not fit (the program must be relinked using a larger -headerpad value) I Tried to not code-sign the executable but then notarization fails: see #5437 I'm reverting this, so we can open a new PR but test the macOS build before merging :) @arthuro555 you can open the PR again with |
I don't have any accesses to this repository, so I cannot create a branch on it. I don't think the CI will build experimental builds if I prefix a branch on my fork |
Unfortunately it won't indeed. Can you re-open a new PR and we will make a branch experimental-build for it? Include the change to config.yml you can see in https://github.com/4ian/GDevelop/pull/5437/files - it's temporary but will allow the branch we'll do to actually do the code signing (and so, we can actually test fixes). I wonder if we should open an issue on steamworks.js - seems like the node executables need some flag when building them. |
Adds a steamworks.js integration to GDevelop.
The namespaces
networking
andoverlay
were not implemented because overlay is not released yet and networking only supports old deprecated steam networking instead of the new one.The events were tested by running them in the event sheets, although I could confirm they do not crash the game and do something, I could not always confirm that the correct behavior is yielded since I do not have a real steam game to test on. Notably, I could not test whether or not Steam Input and Steam Workshop were fully working.