Extension variables #6557
Extension variables #6557
Conversation
D8H
force-pushed
the
unify-variable-extension
branch
from
e6a1aed
to
1258a76
Compare
D8H
force-pushed
the
unify-variable-extension
branch
from
1258a76
to
623ddcf
Compare
| Local | ||
| Local, | ||
| ExtensionGlobal, | ||
| Extension |
There was a problem hiding this comment.
As discussed, maybe
| Extension | |
| ExtensionScene | |
There was a problem hiding this comment.
(someone could say that there is no reason "Extension" would mean something tied to the scene, the default "Extension" could as well mean "global variables" that live forever because the extension lives forever when the game runs)
There was a problem hiding this comment.
I agree but I used a different enum value because I was afraid of a confusion in the generator. Maybe we can try to refactor later?
There was a problem hiding this comment.
You mean a confusion if you rename Extension to ExtensionScene?
That should be fairly safe now, the compiler will let you know all the changes to do?
There was a problem hiding this comment.
No, I meant using existing Scene and Global + the scope as there is no "any" variable that can be both Global and ExtensionGlobal but I'm not sure if it would be better or not (or even feasible).
| @@ -39,6 +44,12 @@ export default function OptionsEditorDialog({ | |||
| title={<Trans>{eventsFunctionsExtension.getName()} options</Trans>} | |||
| secondaryActions={[ | |||
| <HelpButton key="help" helpPagePath="/extensions/create" />, | |||
| <RaisedButton | |||
There was a problem hiding this comment.
Ok for now but we really need to move it to a tree item soon then! :)
GDevelop.js/__tests__/GDJSExtensionVariableCodeGenerationIntegrationTests.js
Show resolved
Hide resolved
GDevelop.js/__tests__/GDJSExtensionVariableCodeGenerationIntegrationTests.js
Show resolved
Hide resolved
Changes
ArbitraryEventsWorkerWithContextinheritance to avoid bad segment crashes.data.json