Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add jsfx sound effects editor, refactor some of piskel's code... #695

Merged
merged 10 commits into from
Oct 20, 2018
Merged

Add jsfx sound effects editor, refactor some of piskel's code... #695

merged 10 commits into from
Oct 20, 2018

Commits on Oct 13, 2018

  1. Add jsfx sound effects editor, refactor some of piskel's code to 

    make it easier to reuse
    @blurymind
    blurymind committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    80aa1eb View commit details
    Browse the repository at this point in the history

  2. clean up

    @blurymind
    blurymind committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    29f7525 View commit details
    Browse the repository at this point in the history

  3. further cleanup

    @blurymind
    blurymind committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    2b7caf5 View commit details
    Browse the repository at this point in the history

  4. more cleanup

    @blurymind
    blurymind committed Oct 13, 2018
    Configuration menu
    Copy the full SHA
    25f5550 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2018

  1. Refactor code to use new html5 src es-module option 

    - also further clean up code and apply @4ian's advice
- loading is now much more robust
- setting and getting metatags is much more robust now

more on the new es-modules option in browsers:
https://jakearchibald.com/2017/es-modules-in-browsers/
    @blurymind
    blurymind committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    3c21e33 View commit details
    Browse the repository at this point in the history

  2. tweak jsfx window 

    size, notes, ui
    @blurymind
    blurymind committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    c404770 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2018

  1. apply review notes wip

    @blurymind
    blurymind committed Oct 16, 2018
    Configuration menu
    Copy the full SHA
    ec6628b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. jsfx and path editor- get rid of global variable, use parameters 

    This commit minimizes the use of global variables in jsfx-main and the patheditor
    @blurymind
    blurymind committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    becddea View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2018

  1. fix flow, apply review notes, cleanup 

    should pass flow test now
    @blurymind
    blurymind committed Oct 18, 2018
    Configuration menu
    Copy the full SHA
    4d0185d View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2018

  1. expose background color in modalWindow, add option to wait for dom... 

    ...to load before showing the window
    @blurymind
    blurymind committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    82442fe View commit details
    Browse the repository at this point in the history