allow math operations in madcow. #50
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patsimon
suggested changes
Apr 28, 2017
| } | ||
|
|
||
| //checks if the entered variable is valid within string | ||
| public static boolean isValidJavaIdentifier(String s) { |
There was a problem hiding this comment.
Does this need to be public and static?
| if (!Character.isJavaIdentifierStart(s.charAt(0))) { | ||
| return false; | ||
| } | ||
| for (int i = 1; i < s.length(); i++) { |
There was a problem hiding this comment.
refactor to return s.toCharArray().every { Character.isJavaIdentifierPart(it) }
patsimon
suggested changes
Apr 28, 2017
| } | ||
|
|
||
| @Test | ||
| void testEvalMath() { |
There was a problem hiding this comment.
Can we please get another test case for the negative case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.