Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-72417 #40

Closed
wants to merge 83 commits into from
Closed

LPS-72417 #40

wants to merge 83 commits into from

Conversation

adolfopa
Copy link

@adolfopa adolfopa commented May 9, 2017 •
edited by 4lejandrito

No description provided.

@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/collaboration/wiki/.gitrepo'.
9754e85
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/sync/.gitrepo'.
addf254
@brianchandotcom
LPS-72398 Do not fail if the locale is not available
17b6c86
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/web-experience/export-import/.git…
618c1fa 
…repo'.
@vicnate5 @brianchandotcom
LRQA-32348 Disable instances for email test
3763796
@janditibi @brianchandotcom
LPS-72312 Page icons are not rendered in the Navigation Menu
b21dc4a
@michaelhashimoto @liferay-continuous-integration
LRQA-32434 Break the integration tests into 7 different axis builds
73e665b
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/web-experience/journal/.gitrepo'.
6804de2
@ealonso @liferay-continuous-integration
LPS-72390 Copy from ImageJournalUploadHandler, no logic changes
1fc93e4
@4lejandrito @liferay-continuous-integration
LPS-72390 Apply changes
fe578ba
@4lejandrito @liferay-continuous-integration
LPS-72390 Uses the new upload classes
56651df
@4lejandrito @liferay-continuous-integration
LPS-72390 build.gradle
5f1bc3d
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/web-experience/journal/.gitrepo'.
97c72ac
@koor4356 @brianchandotcom
LRQA-32329 Update locator for open pages
8c53319
@koor4356 @brianchandotcom
LRQA-32329 Update locator for bookmark detail link
a77911d
@brianchandotcom @liferay-continuous-integration
LPS-72027 not needed
60ebd90
@brianchandotcom @liferay-continuous-integration
LPS-72027 In core, I often allow "_embeddedRelatedModels" to be a map…
dec8b9e 
… of "embeddedRelatedModels" where "embeddedRelatedModels" is a list. I'm OK with this because the prefix "_" tells me it's a class level var. Notice that we are inconsistent even with your change, because "_identifierFunctions" would have to be called "_identifierFunctionsMap" and we would have to use "embeddedRelatedModelsList" and "_embeddedRelatedModelsListsMap".
@brianchandotcom @liferay-continuous-integration
LPS-72027 the method is addEmbedded and addLink, hence embeddedRelate…
a214433 
…dModels and linkRelatedModels, not linkedRelatedModels. If you want to call it linkedRelatedModels, then change the method addLink to addLinked.
@brianchandotcom @liferay-continuous-integration
LPS-72027 I find chaining like this to be "not pretty" because it is …
55a7af2 
…one step closer to obfuscating code. I prefer to spell things out.
@brianchandotcom @liferay-continuous-integration
LPS-72027 Follow the usage of the constructor, or sort them. It was f…
635c00a 
…ollowing neither pattern.
@brianchandotcom @liferay-continuous-integration
LPS-72027 as used
d142385
@brianchandotcom @liferay-continuous-integration
LPS-72027 There's only one Optional here. If we have more, then follo…
6660325 
…w the scheme you just used.
@brianchandotcom @liferay-continuous-integration
LPS-72027 SF
bce78e4
@brianchandotcom @liferay-continuous-integration
LPS-72027 Sort
678313a
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/vulcan/.gitrepo'.
98ef84d
@ealonso @liferay-continuous-integration
LPS-72218 We shouldn't depend on Trash
0981595
@ealonso @liferay-continuous-integration
LPS-72218 Set trashed models
b5b75de
@ealonso @liferay-continuous-integration
LPS-72218 uses new interface journal-service
c0c8bbb
@ealonso @liferay-continuous-integration
LPS-72218 uses new interface journal-web
04afe43
@ealonso @liferay-continuous-integration
LPS-72218 Uses new interface on test
2a6b15e
shuyangzhou and others added 24 commits May 8, 2017 16:11
@shuyangzhou @brianchandotcom
LPS-72343 Use our standard toString format.
9828163
@shuyangzhou @brianchandotcom
LPS-72343 Generics
6965970
@shuyangzhou @brianchandotcom
LPS-72343 Use HashMapDictionary instead of Hashtable
321798d
@brianchandotcom
LPS-72343 SF
326d64c
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/portal-search/.gitrepo'.
2c6217d
@inacionery @liferay-continuous-integration
LPS-72421 Get the create date and modified date from serviceContext
a507325
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/forms-and-workflow/portal-workflo…
c7f6e93 
…w/.gitrepo'.
@Preston-Crary @brianchandotcom
LPS-72407 Improve performance of DLFileEntryTypeImpl.getUnambiguousNa…
6501b6f 
…me().
@brianchandotcom
LPS-72444 Updates to gulp-metal@2.0.2
34d073c
@brianchandotcom
LPS-72444 Updates npm-shrinkwrap (auto-generated)
871f82c
@brianchandotcom
LPS-70497 - SF
e7c05b8
@thektan @brianchandotcom
LPS-72323 - Confirm fired formReady event is element's form before fo…
272481b 
…cusing
@thektan @brianchandotcom
LPS-72323 - Remove unnecessary check for event
e56133b
@brianchandotcom
LPS-72323 SF
ab7f0cb
@antonio-ortega @brianchandotcom
LPS-72179 Add label for day abbreviation
9faa8e9
@antonio-ortega @brianchandotcom
LPS-72179 Using internationalized date format value
c46af8d
@antonio-ortega @brianchandotcom
LPS-72179 Adding translations to ES and EU locales
1c8182d
@dustinryerson @brianchandotcom
LPS-72179 Convert placeholderValue to lower case
832ec46
@brianchandotcom
LPS-72179 SF
83d5520
@liferay-continuous-integration
subrepo:ignore Update 'modules/apps/foundation/frontend-js/.gitrepo'.
0f8730d
@4lejandrito @adolfopa
LPS-72417 Adding getResourceBundle method to allow subclasses to prov…
315779c 
…ide their own
@4lejandrito @adolfopa
LPS-72417 Baseline
850648b
@adolfopa
LPS-72417 Reduce method visibility
1cf8a16 
If this method is intended only for subclasses to override, it should
be protected, not public.
@adolfopa
LPS-72417 SF
708d362
@liferay-continuous-integration
Copy link
Collaborator

Pull request test invoked at http://test-1-9.liferay.com/job/test-portal-acceptance-pullrequest(master).

@adolfopa adolfopa mentioned this pull request May 9, 2017
Closed
@liferay-continuous-integration
Copy link
Collaborator

All tests PASSED.

Build Time: 1 hour 20 minutes 37 seconds 913 ms

Base Branch:

Branch Name: master
Branch GIT ID: 0f8730ddf4cd34525dd966f4eae569510569f139

Job Summary:

For more details click here.

@4lejandrito
Copy link
Owner

Just started reviewing :)

:octocat: Sent from GH.

@4lejandrito
Copy link
Owner

Pull request submitted to brianchandotcom#48902.

:octocat: Sent from GH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone