WIP: Feature/textarea autocomplete #380
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The quick-add-items field now shows a list of all available items after the users enters the character `#`.
Issue: The datasource is not reactive which means that new responsibles / labels will only be shown after a reload of the page...
Query the necessary data (responsibles / labels) inside an `autorun`-block and set the result as a reactive var. This ensures that the data are update reactively.
... otherwise the data is not necessary.
The implementation for qurying responsibles has changed completely (incl. the interface for using the module!). To enable merging in the changes I disable the feature and wire it together later on.
…entered multiple times in the input field
It turned out that the old implementation of `currentDatePlusDeltaDays` didn't work exactly. The test case which passes -35 as delta in days failed since the function returned a date off by one. Ridiculously, the test case passed on all other days except today. With this small change in the implementation the tests passes again...
felixble
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fetch the additional responsibles I use the new
responsiblesSearchMeteor method together with theParticipantsPrepareras it was introduced in the feature #356. Unfortunately, the interfaces are not really clear and straightforward. I think we should clean this up a litte bit in the future.Since my focus with this PR lies on the implementation on the new feature which will be a great benefit for our users I didn't spent much time for cleaning up the existing code...
See #381