Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no null protect in FlexibleRowBuilder setString #3637

Closed
vagetablechicken opened this issue Nov 29, 2023 · 0 comments · Fixed by #3649
Closed

no null protect in FlexibleRowBuilder setString #3637

vagetablechicken opened this issue Nov 29, 2023 · 0 comments · Fixed by #3649
Assignees
@dl239
Labels
bug Something isn't working sdk openmldb java/python sdk

Comments

@vagetablechicken
Copy link
Collaborator

vagetablechicken commented Nov 29, 2023 •
edited

OpenMLDB/java/openmldb-common/src/main/java/com/_4paradigm/openmldb/common/codec/FlexibleRowBuilder.java

Line 340 in b005cd1

byte[] bytes = val.getBytes(CodecUtil.CHARSET);

if val is null, we'll get an error:

java.lang.NullpointerException: null
at com._4paradigm.openmldb.common.codec.FlexibleRowBuilder.setstring(FlexibleRowBuilder.java:337)
at com._4paradigm.openmldb,sdk.impl.BatchcallablepreparedstatementImpl,setstring(BatchcallablereparedstatementImpl.java:215)
@vagetablechicken vagetablechicken changed the title no null protect in setString no null protect in FlexibleRowBuilder setString Nov 29, 2023
@dl239 dl239 mentioned this issue Nov 30, 2023
Merged
@aceforeverd aceforeverd added sdk openmldb java/python sdk bug Something isn't working labels Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dl239 dl239

Labels
bug Something isn't working sdk openmldb java/python sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: throw null pointer exception if the set value is null in RowBuilder dl239/OpenMLDB
3 participants
@dl239 @aceforeverd @vagetablechicken