Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw null pointer exception if the set value is null in RowBuilder #3649

Merged
merged 4 commits into from
Dec 26, 2023

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Nov 30, 2023

close #3637

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (71cf61e) 74.94% compared to head (314f2f2) 40.24%.
Report is 1 commits behind head on main.

Files Patch % Lines
...adigm/openmldb/common/codec/ClassicRowBuilder.java 66.66% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3649       +/-   ##
=============================================
- Coverage     74.94%   40.24%   -34.70%     
- Complexity      640      648        +8     
=============================================
  Files           724      191      -533     
  Lines        130414    11245   -119169     
  Branches       1325     1329        +4     
=============================================
- Hits          97743     4526    -93217     
+ Misses        32378     6421    -25957     
- Partials        293      298        +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 30, 2023
@dl239 dl239 requested a review from lqy222 December 11, 2023 04:12
@dl239 dl239 merged commit 7a62b70 into 4paradigm:main Dec 26, 2023
21 of 23 checks passed
@dl239 dl239 deleted the fix/set_null branch December 26, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no null protect in FlexibleRowBuilder setString
3 participants