Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: translate the Chinese doc of faq.md into English (#1796) #1812

Closed
wants to merge 4 commits into from
Closed

docs: translate the Chinese doc of faq.md into English (#1796) #1812

wants to merge 4 commits into from

Conversation

jmoldyvan
Copy link
Contributor

@jmoldyvan jmoldyvan commented May 13, 2022

I would like to add, if the translation/file gets merges is correct/file gets merged, I can do the other files

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    docs: translation faq.md from Chinese to English
    close docs: translate the Chinese doc of faq.md into English #1796

  • What is the current behavior? (You can also link to an open issue here)
    an faq docs listing some questions

  • What is the new behavior (if this is a feature change)?
    same behavior just a translation

@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 13, 2022
Copy link
Collaborator

@lumianph lumianph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jmoldyvan thank you for your contribution very much!
However, please do not revise the Chinese version directly, please do the following:

  1. Save the new English version as docs/en/maintain/faq.md
  2. Add the page entry to the file docs/en/maintain/index.rst (you can just add an item faq after cli)

@jmoldyvan
Copy link
Contributor Author

yeah no problem, i can fix that up. thanks for the reply!

@jmoldyvan
Copy link
Contributor Author

I'll probably just make a new pr by the way

@lumianph
Copy link
Collaborator

no problem, we really appreciate your contribution.

@jmoldyvan jmoldyvan closed this May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: translate the Chinese doc of faq.md into English
2 participants