Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused gflag variable #1775

Closed
dl239 opened this issue May 9, 2022 · 2 comments · Fixed by #1777
Closed

Remove unused gflag variable #1775

dl239 opened this issue May 9, 2022 · 2 comments · Fixed by #1777
Assignees
@bxiiiiii
Labels
good first issue Good for newcomers

Comments

@dl239
Copy link
Collaborator

dl239 commented May 9, 2022 •
edited
Loading

enable_timeseries_table is unused currently. it need to delete from the following files:

  • src/flags.cc
  • src/nameserver/standalone_test.cc
  • src/nameserver/name_server_test.cc
  • src/nameserver/name_server_impl.cc
@dl239 dl239 added the good first issue Good for newcomers label May 9, 2022
@bxiiiiii
Copy link
Contributor

bxiiiiii commented May 9, 2022

Please assign it to me.

@lumianph
Copy link
Collaborator

lumianph commented May 9, 2022

@bxiiiiii looking forward to your PR

@jmoldyvan jmoldyvan mentioned this issue May 9, 2022
Merged
aceforeverd pushed a commit that referenced this issue May 10, 2022
@jmoldyvan
Fix: Remove unused gflag variable (#1775) (#1777)
e0a1771
@lumianph lumianph mentioned this issue May 10, 2022
Closed
@Cupid0320 Cupid0320 mentioned this issue May 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bxiiiiii bxiiiiii

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove unused gflag variable (#1775)
3 participants
@lumianph @dl239 @bxiiiiii