Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show components result is wrong #2940

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jan 9, 2023

WX20230103-162409

reproduce steps:

  • start OpenMLDB cluster with two or more nameserver
  • restart nameserver leader
  • execute show components; command

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 76.11% // Head: 76.10% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d4dbf93) compared to base (d7ec38f).
Patch coverage: 83.33% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2940      +/-   ##
============================================
- Coverage     76.11%   76.10%   -0.01%     
  Complexity      393      393              
============================================
  Files           653      653              
  Lines        123412   123413       +1     
  Branches       1096     1096              
============================================
- Hits          93936    93928       -8     
- Misses        29240    29249       +9     
  Partials        236      236              
Impacted Files Coverage Δ
src/sdk/sql_cluster_router.cc 62.22% <83.33%> (-0.07%) ⬇️
...s/query_response_time/deploy_query_response_time.h 81.25% <0.00%> (-18.75%) ⬇️
src/rpc/rpc_client.h 70.78% <0.00%> (-4.50%) ⬇️
...atistics/query_response_time/query_response_time.h 78.26% <0.00%> (-4.35%) ⬇️
.../query_response_time/deploy_query_response_time.cc 97.10% <0.00%> (-2.90%) ⬇️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/catalog/client_manager.h 29.06% <0.00%> (-1.17%) ⬇️
src/replica/log_replicator.cc 82.31% <0.00%> (-0.33%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.26% <0.00%> (-0.32%) ⬇️
src/catalog/client_manager.cc 43.05% <0.00%> (-0.29%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

SDK Test Report

  84 files    84 suites   1m 22s ⏱️
178 tests 171 ✔️ 7 💤 0
224 runs  217 ✔️ 7 💤 0

Results for commit d4dbf93.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2023

Linux Test Report

590 tests   583 ✔️  27m 0s ⏱️
  58 suites      7 💤
  52 files        0

Results for commit d4dbf93.

@dl239 dl239 enabled auto-merge (squash) January 10, 2023 06:45
Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dl239 dl239 merged commit 9c37b3f into 4paradigm:main Jan 10, 2023
@dl239 dl239 linked an issue Jan 11, 2023 that may be closed by this pull request
@dl239 dl239 deleted the fix/show_component branch January 12, 2023 02:41
tobegit3hub added a commit that referenced this pull request Jan 14, 2023
* docs: sdk optimization (#2904)

* docs: add error code and fix beginner read (#2925)

* docs: add error code in index (#2928)

* feat: update docker version (#2924)

* docs: move and optimize founction_boundary.md  (#2921)

* fix: fix tablet coredump (#2926)

* fix: deploy failed if the column name of main table is keyword (#2894)

* docs: fix hive export desc (#2934)

* refactor: delete root_path_dir after run case (#2875)

* docs: add concept file in quickstart file/ optimize modes.md (#2932)

* feat: upgrade version (#2937)

* fix: show components result is wrong (#2940)

* fix: disk table memory leak (#2943)

* docs: quickstart improvement (#2945)

* fix: set guava version for openmldb-batch (#2936)

* feat: improve cmd and interactive in sql client (#2898)

* feat: update docs of monitoring (#2946)

* docs: improve the chinese docs of high availability (#2952)

* docs: fix conf.md (#2954)

* fix: disable DeployStats log (#2953)

* docs: add notebook integration to the ecosystem (#2942)

* feat: create table like (#2949)

* feat: create table like parquet

* feat: create table like hive

Co-authored-by: ZHANG Hao <zhanghao@4paradigm.com>

* feat: support soft import from hive  (#2948)

* feat: support soft import from hive

* fix: distribute iterator value invalid (#2939)

* docs: release 0.7.1 (#2947)

* feat: offline support create table like hive (#2962)

* feat: add the docs of create table like (#2964)

* Add the docs of create table like

* Add known issues docs for create table like hive (#2965)

Co-authored-by: 陈景欣 <117905435+selenachenjingxin@users.noreply.github.com>
Co-authored-by: HuangWei <huangwei@apache.org>
Co-authored-by: LU MIAN <lumianph@gmail.com>
Co-authored-by: tobe <tobeg3oogle@gmail.com>
Co-authored-by: aceforeverd <teapot@aceforeverd.com>
Co-authored-by: ZHANG Hao <zhanghao@4paradigm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ns_role is not changed after nameserver leader restart
3 participants