Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disk table memory leak #2943

Merged
merged 2 commits into from
Jan 10, 2023
Merged

fix: disk table memory leak #2943

merged 2 commits into from
Jan 10, 2023

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Jan 10, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

@github-actions github-actions bot added the storage-engine openmldb storage engine. nameserver & tablet label Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 76.11% // Head: 76.12% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (1f17ff1) compared to base (d7ec38f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2943      +/-   ##
============================================
+ Coverage     76.11%   76.12%   +0.01%     
  Complexity      393      393              
============================================
  Files           653      653              
  Lines        123412   123413       +1     
  Branches       1096     1096              
============================================
+ Hits          93936    93950      +14     
+ Misses        29240    29227      -13     
  Partials        236      236              
Impacted Files Coverage Δ
src/storage/disk_table.cc 81.26% <100.00%> (+0.02%) ⬆️
src/zk/dist_lock.cc 81.81% <0.00%> (-1.52%) ⬇️
src/replica/log_replicator.cc 82.31% <0.00%> (-0.33%) ⬇️
hybridse/src/codec/fe_row_codec.cc 78.26% <0.00%> (-0.32%) ⬇️
src/catalog/client_manager.cc 43.05% <0.00%> (-0.29%) ⬇️
src/zk/zk_client.cc 83.37% <0.00%> (-0.26%) ⬇️
src/sdk/sql_cluster_router.cc 62.17% <0.00%> (-0.12%) ⬇️
src/nameserver/name_server_impl.cc 44.77% <0.00%> (+0.04%) ⬆️
src/tablet/tablet_impl.cc 63.72% <0.00%> (+0.38%) ⬆️
src/storage/mem_table.cc 89.56% <0.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023

SDK Test Report

  84 files    84 suites   1m 36s ⏱️
178 tests 171 ✔️ 7 💤 0
224 runs  217 ✔️ 7 💤 0

Results for commit 1f17ff1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2023

Linux Test Report

590 tests   583 ✔️  26m 51s ⏱️
  58 suites      7 💤
  52 files        0

Results for commit 1f17ff1.

♻️ This comment has been updated with latest results.

@dl239 dl239 merged commit 418c82d into 4paradigm:main Jan 10, 2023
@dl239 dl239 deleted the fix/memory_leak branch January 10, 2023 10:02
tobegit3hub added a commit that referenced this pull request Jan 14, 2023
* docs: sdk optimization (#2904)

* docs: add error code and fix beginner read (#2925)

* docs: add error code in index (#2928)

* feat: update docker version (#2924)

* docs: move and optimize founction_boundary.md  (#2921)

* fix: fix tablet coredump (#2926)

* fix: deploy failed if the column name of main table is keyword (#2894)

* docs: fix hive export desc (#2934)

* refactor: delete root_path_dir after run case (#2875)

* docs: add concept file in quickstart file/ optimize modes.md (#2932)

* feat: upgrade version (#2937)

* fix: show components result is wrong (#2940)

* fix: disk table memory leak (#2943)

* docs: quickstart improvement (#2945)

* fix: set guava version for openmldb-batch (#2936)

* feat: improve cmd and interactive in sql client (#2898)

* feat: update docs of monitoring (#2946)

* docs: improve the chinese docs of high availability (#2952)

* docs: fix conf.md (#2954)

* fix: disable DeployStats log (#2953)

* docs: add notebook integration to the ecosystem (#2942)

* feat: create table like (#2949)

* feat: create table like parquet

* feat: create table like hive

Co-authored-by: ZHANG Hao <zhanghao@4paradigm.com>

* feat: support soft import from hive  (#2948)

* feat: support soft import from hive

* fix: distribute iterator value invalid (#2939)

* docs: release 0.7.1 (#2947)

* feat: offline support create table like hive (#2962)

* feat: add the docs of create table like (#2964)

* Add the docs of create table like

* Add known issues docs for create table like hive (#2965)

Co-authored-by: 陈景欣 <117905435+selenachenjingxin@users.noreply.github.com>
Co-authored-by: HuangWei <huangwei@apache.org>
Co-authored-by: LU MIAN <lumianph@gmail.com>
Co-authored-by: tobe <tobeg3oogle@gmail.com>
Co-authored-by: aceforeverd <teapot@aceforeverd.com>
Co-authored-by: ZHANG Hao <zhanghao@4paradigm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants