Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure a crawler_site_id by default. #106

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Conversation

jone
Copy link
Member

@jone jone commented Nov 7, 2017

ftw.crawler now supports to configure a crawler_site_id. This change adds such a field for all solr cores by default. See 4teamwork/ftw.crawler#9

By adding the crawler_site_id field to the core template, all solr installation based on this buildout config will automatically receive the field for all cores, making it easier for developers to adapt to this feature.
It isn't necessary to have the field on regulare cores, but it is easier to add it to all cores in ftw-buildouts than to add the field in each project separately.

config-version:
The collective.recipe.solrinstance does not properly update the configuration: it only reinstalls when values of its part change. When configurations of the cores change, those changes are not in the solrinstance part and thus the recipe does not reinstall and the change is not applied.
As workaround we introduce a config-version value which is simply incremented and will trigger a reinstall of the solr part whenever incremented.

ftw.crawler now supports to configure a crawler_site_id.
This change adds such a field for all solr cores by default.
@jone jone requested a review from lukasgraf November 7, 2017 07:13
Copy link
Contributor

@maethu maethu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me.

@jone jone merged commit 49c5cdc into master Feb 23, 2018
@jone jone deleted the jone-crawler-site-id branch February 23, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants