Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin down setuptools and more-itertools for Python 2 #175

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

jone
Copy link
Member

@jone jone commented Jan 13, 2020

Attempt to fix our broken builds. Currently a lot of python2 builds are failing because setuptools was not pinned up to now:

Example: https://ci.4teamwork.ch/builds/301717/tasks/496024

setuptools and more-itertools need to be pinned down for python2 buildouts to a version that has still python2 support.

In order for that to work properly in Plone 5, we need to split up the versions file into python 2 and python 3 versions.

setuptools and more-itertools need to be pinned down for python2
buildouts to a version that has still python2 support.
Copy link
Member

@lukasgraf lukasgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

@lukasgraf lukasgraf merged commit e1a3f66 into master Jan 13, 2020
@lukasgraf lukasgraf deleted the jone-pin-down-versions branch January 13, 2020 16:53
@djowett-ftw
Copy link
Contributor

Good stuff - thanks @jone !
I can foresee a lot of pins becoming necessary in the next few weeks/months - it's good to be able to centralize that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants