Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin down setuptools and more-itertools for Python 2 #175

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@jone
Copy link
Member

jone commented Jan 13, 2020

Attempt to fix our broken builds. Currently a lot of python2 builds are failing because setuptools was not pinned up to now:

Example: https://ci.4teamwork.ch/builds/301717/tasks/496024

setuptools and more-itertools need to be pinned down for python2 buildouts to a version that has still python2 support.

In order for that to work properly in Plone 5, we need to split up the versions file into python 2 and python 3 versions.

@jone jone requested review from buchi, lukasgraf and djowett-ftw Jan 13, 2020
setuptools and more-itertools need to be pinned down for python2
buildouts to a version that has still python2 support.
@jone jone force-pushed the jone-pin-down-versions branch from 8ec2bac to e99429a Jan 13, 2020
Copy link
Member

lukasgraf left a comment

LGTM, thanks! 👍

@lukasgraf lukasgraf merged commit e1a3f66 into master Jan 13, 2020
1 check passed
1 check passed
CI Governor: default Task #496181 succeeded
Details
@lukasgraf lukasgraf deleted the jone-pin-down-versions branch Jan 13, 2020
@djowett-ftw

This comment has been minimized.

Copy link

djowett-ftw commented Jan 13, 2020

Good stuff - thanks @jone !
I can foresee a lot of pins becoming necessary in the next few weeks/months - it's good to be able to centralize that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.