Merge pull request #28 from 4teamwork/ne/edit-permission-fix

Fix edit permissions for addressblock
4teamwork · May 22, 2019 · 098702f · 098702f
2 parents 902b1f4 + ad32f8e
commit 098702f
Show file tree

Hide file tree

Showing 6 changed files with 28 additions and 0 deletions.
diff --git a/docs/HISTORY.txt b/docs/HISTORY.txt
@@ -5,6 +5,7 @@ Changelog
 1.2.1 (unreleased)
 ------------------
 
+- Fix edit permissions for addressblock [Nachtalb]
 - Add zoomlevel and maplayers support for addressblocks [Nachtalb]
 
 

diff --git a/ftw/addressblock/profiles/default/types/ftw.addressblock.AddressBlock.xml b/ftw/addressblock/profiles/default/types/ftw.addressblock.AddressBlock.xml
@@ -49,6 +49,7 @@
     <action title="Edit" action_id="edit" category="object" condition_expr=""
             description="" icon_expr="" link_target=""
             url_expr="string:${object_url}/edit" visible="True">
+            <permission value="Modify portal content"/>
     </action>
 
 </object>
diff --git a/ftw/addressblock/profiles/default_plone5/types/ftw.addressblock.AddressBlock.xml b/ftw/addressblock/profiles/default_plone5/types/ftw.addressblock.AddressBlock.xml
@@ -49,6 +49,7 @@
     <action title="Edit" action_id="edit" category="object" condition_expr=""
             description="" icon_expr="" link_target=""
             url_expr="string:${object_url}/edit" visible="True">
+            <permission value="Modify portal content"/>
     </action>
 
 </object>
diff --git a/ftw/addressblock/upgrades/20190521172501_add_missing_permission_for_editing/__init__.py b/ftw/addressblock/upgrades/20190521172501_add_missing_permission_for_editing/__init__.py
diff --git a/...20190521172501_add_missing_permission_for_editing/types/ftw.addressblock.AddressBlock.xml b/...20190521172501_add_missing_permission_for_editing/types/ftw.addressblock.AddressBlock.xml
@@ -0,0 +1,16 @@
+<?xml version="1.0"?>
+<object name="ftw.addressblock.AddressBlock">
+
+  <action title="Edit"
+          action_id="edit"
+          category="object"
+          condition_expr=""
+          description=""
+          icon_expr=""
+          link_target=""
+          url_expr="string:${object_url}/edit"
+          visible="True">
+    <permission value="Modify portal content"/>
+  </action>
+
+</object>
diff --git a/ftw/addressblock/upgrades/20190521172501_add_missing_permission_for_editing/upgrade.py b/ftw/addressblock/upgrades/20190521172501_add_missing_permission_for_editing/upgrade.py
@@ -0,0 +1,9 @@
+from ftw.upgrade import UpgradeStep
+
+
+class AddMissingPermissionForEditing(UpgradeStep):
+    """Add missing permission for editing.
+    """
+
+    def __call__(self):
+        self.install_upgrade_profile()