Changed utility method IAvatarGenerator.generate to take userid instead of full name. #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of full name. This makes the utility more flexible while overwriting because the user can now be identified accurately.
| @@ -2,10 +2,13 @@ Changelog | |||
| ========= | |||
|
|
|||
|
|
|||
| 1.0.8 (unreleased) | |||
| 2.0.0 (unreleased) | |||
There was a problem hiding this comment.
I would release it as 1.1.0, not 2.0.0, as it is just a backwards incompatible API change and not a complete rewrite 😉
If you change it in setup.py too, zest.releaser will propose it correctly.
There was a problem hiding this comment.
@jone But a backwards incompatible API change is the DEFINITON of a major version: http://semver.org/
If we use 1.1.0 others will think this is a backwards compatible update and will update it without a second thought. And then things break and people get angry. 😉
|
👍 Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the utility more flexible while overwriting because the user can now be identified accurately.
My use-case is to take a custom property on the member object and generate an icon from that.
This is currently not possible because ftw.avatar passes the
fullnameto theIAvatarGenerator.generatemethod. I can't safely identify the user with this information.This PR moves the functionality to generate an avatar from the
fullnameentirely into the default implementation. This allows a products to override this and use entirely different user information to generate the icon.