Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrow to 'more'-button #41

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Conversation

busykoala
Copy link
Contributor

@busykoala busykoala commented Dec 4, 2018

image

To create a similar appearance as in ftw.news this change adds
an arrow in front of the 'more'-button as there i one in front
of it in ftw.news.

@busykoala busykoala self-assigned this Dec 4, 2018
ftw/events/browser/resources/events.scss Outdated Show resolved Hide resolved
ftw/events/browser/configure.zcml Outdated Show resolved Hide resolved
Copy link
Contributor

@mbaechtold mbaechtold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please describe your changes in the HISTORY.txt?

Two screenshots (before and after your change) would be very nice (in the description of the pull request).

@busykoala
Copy link
Contributor Author

For me the arrow still does not appear, even when opened in a anonymous window.
The history entry I can do of course.

docs/HISTORY.txt Outdated Show resolved Hide resolved
@busykoala busykoala force-pushed the mo/add_arrow_in_more_btn branch 3 times, most recently from cb97b10 to a8fe1d3 Compare December 5, 2018 07:36
Copy link
Contributor

@mbaechtold mbaechtold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the two commits.

To create a similar appearance as in ftw.news this change add
an arrow in front of the 'more'-button as there i one in front
of it in ftw.news.
@busykoala
Copy link
Contributor Author

I squashed them together.

Copy link
Contributor

@mbaechtold mbaechtold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you!

@mbaechtold mbaechtold merged commit e43d9c6 into master Dec 5, 2018
@mbaechtold mbaechtold deleted the mo/add_arrow_in_more_btn branch December 5, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants