Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests after ftw.testing release. #17

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Fix tests after ftw.testing release. #17

merged 1 commit into from
Nov 12, 2019

Conversation

jone
Copy link
Member

@jone jone commented Nov 12, 2019 •
edited
Loading

Use unittest instead of unittest2 (dependency was not declared).

@jone
Use old version of ftw.testing.
d9cee33 
Downgrad ftw.testing so that mock tests still work.
@jone jone requested a review from a team November 12, 2019 15:19
@jone jone changed the title Use old version of ftw.testing. Fix tests after ftw.testing release. Nov 12, 2019
Nachtalb
Nachtalb suggested changes Nov 12, 2019
View reviewed changes
Copy link
Contributor

@Nachtalb Nachtalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is ok but the commit message tells about downgrading ftw.testing instead of replacing unittest2 with unittest

@jone
Copy link
Member Author

jone commented Nov 12, 2019

The change is ok but the commit message tells about downgrading ftw.testing instead of replacing unittest2 with unittest

That's a systematic problem. I updated the PR title / description, that's good enough 😞

@jone jone requested a review from Nachtalb November 12, 2019 17:45
@jone jone merged commit a33a13d into master Nov 12, 2019
@jone jone deleted the jone-tests branch November 12, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nachtalb Nachtalb Nachtalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jone @Nachtalb