Add ftw.theming:default profile. #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essential features provided by ftw.simplelayout are not working without the profile ftw.theming:default. Therefore it makes sence to add it to the profiles installed on initialization. I do not add an upgrade step based on the assumption that existing installations using ftw.simplelayout solved the problem already.
jone
approved these changes
Nov 1, 2019
There was a problem hiding this comment.
This makes ftw.theming a non-optional requirement for ftw.simplelayout.
I think this is a good decision, because simplelayout does not provide any workable plone-vanilla fallback and ftw.theming is already a standard requirement that is not listed as an extra.
@maethu what is your opinion on that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Essential features provided by ftw.simplelayout are not working without the profile ftw.theming:default. Therefore it makes sence to add it to the profiles installed on initialization. I do not add an upgrade step based on the assumption that existing installations using ftw.simplelayout solved the problem already.