Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ftw.theming:default profile. #555

Merged
merged 1 commit into from Nov 1, 2019

Conversation

@busykoala
Copy link
Contributor

busykoala commented Nov 1, 2019

Essential features provided by ftw.simplelayout are not working without the profile ftw.theming:default. Therefore it makes sence to add it to the profiles installed on initialization. I do not add an upgrade step based on the assumption that existing installations using ftw.simplelayout solved the problem already.

Essential features provided by ftw.simplelayout are not working without the profile ftw.theming:default. Therefore it makes sence to add it to the profiles installed on initialization. I do not add an upgrade step based on the assumption that existing installations using ftw.simplelayout solved the problem already.
@busykoala busykoala requested a review from 4teamwork/plone Nov 1, 2019
@busykoala busykoala self-assigned this Nov 1, 2019
@jone
jone approved these changes Nov 1, 2019
Copy link
Member

jone left a comment

This makes ftw.theming a non-optional requirement for ftw.simplelayout.
I think this is a good decision, because simplelayout does not provide any workable plone-vanilla fallback and ftw.theming is already a standard requirement that is not listed as an extra.

@maethu what is your opinion on that?

@jone jone requested a review from maethu Nov 1, 2019
@maethu
maethu approved these changes Nov 1, 2019
Copy link
Member

maethu left a comment

I like

@maethu maethu merged commit 9bfdcdc into master Nov 1, 2019
3 checks passed
3 checks passed
CI Governor: test-javascript.cfg Task #462379 succeeded
Details
CI Governor: test-plone-4.3.x.cfg Task #462380 succeeded
Details
CI Governor: test-plone-5.1.x.cfg Task #462381 succeeded
Details
@maethu maethu deleted the mo/add_theming_profile branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.