Make subsitelogoviewlet more robust #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raphael-s, could you please add a test? |
mbaechtold
suggested changes
Nov 28, 2016
| @@ -19,13 +19,14 @@ def __init__(self, context, request, view, manager=None): | |||
| def update(self): | |||
| super(SubsiteLogoViewlet, self).update() | |||
|
|
|||
| portal = api.portal.get() | |||
There was a problem hiding this comment.
I would move that to the else as portal is only used there.
raphael-s
force-pushed
the
rs-MakeSubsiteLogoViewletMoreRobust
branch
from
bf4dab7
to
138c48a
Compare
raphael-s
force-pushed
the
rs-MakeSubsiteLogoViewletMoreRobust
branch
from
138c48a
to
8a20413
Compare
mbaechtold
approved these changes
Nov 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some previous mistakes I made in #99
subsitelogoviewletshould now be protected against any troubles caused by other content with the idlogocloses #98