Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge v 1.7.17 #1

Merged
merged 25 commits into from
Jul 31, 2019
Merged

merge v 1.7.17 #1

merged 25 commits into from
Jul 31, 2019

Conversation

541595308
Copy link
Owner

No description provided.

Nikita and others added 25 commits July 6, 2018 12:14
#596

reason:
WebSocketTransport line 144 : Packet packet = new Packet(PacketType.MESSAGE); //subType =null
PacketEncoder line 288: byte subType = toChar(packet.getSubType().getValue()); //NullPointerException

fix
WebSocketTransport
Packet packet = new Packet(PacketType.MESSAGE);
packet.setSubType(PacketType.MESSAGE);
socketio.js 2.0 + netty-socketio-1.7.16
reason: 
namespace request payload contains url query string info, like 
`8:40/chat,`
`49:40/chatroom?uid=ba7822bee25940ada9d2a987670afc5d,`

it does'n match `/chat` or `/chatroom` in namespacehub

fix: 
sub the query string
Make it compatible with Spliterator/Stream in java8 by returning a new
iterator each time iterator() is called
@541595308 541595308 merged commit 0fe0d2b into 541595308:source Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants