Remove internal use of Arc from StatsdClient #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Arcs used only so the client could implement the Clone trait. Instead they are replaced with Boxes which don't require reference counting. The implication of this is that users of StatsdClient must wrap it in an Arc if they wish to share references of it between threads. Fixes #162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Arcs used only so the client could implement the Clone trait. Instead
they are replaced with Boxes which don't require reference counting. The
implication of this is that users of StatsdClient must wrap it in an Arc if
they wish to share references of it between threads.
Fixes #162