Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

MGDOBR-1395: add GET connectors feature #1532

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

r00ta
Copy link
Collaborator

@r00ta r00ta commented Jan 20, 2023

MGDOBR-1395

PR owner checklist

Please make sure that your PR meets the following requirements:

  • Your code is properly formatted according to this configuration.
    Run mvn clean verify -DskipTests so that imports are correctly set.
  • Your commit messages are clear and reference the JIRA issue e.g: "[MGDOBR-XXX] - $clear_explanation_of_what_you_did"
  • The layers in the kustomize folder have been updated accordingly.
  • All new functionality is tested
  • Pull Request title is properly formatted: MGDOBR-XYZ Subject
  • Pull Request contains link to the JIRA issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket

PR reviewer(s) checklist

  • Check if code and Github action workflows have been modified and if the modification is safe
  • If the modification is safe, add the safe to test label
How to trigger pipelines and use the bots:
  • Run the end to end pipeline
    Annotate the pull request with the label: safe to test. If you want to run the pipeline again, remove and add it again.

  • Rebase the pull request
    Comment with: /rebase.

  • Deploy BOT
    Comment with `/deploy <dev,stable> when the PR has been merged to deploy to a target environment.

@r00ta r00ta requested a review from manstis January 20, 2023 08:48
@r00ta r00ta marked this pull request as ready for review January 20, 2023 08:51
Copy link
Contributor

@winklerm winklerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

The Connector related class hierarchy is working well.

@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@r00ta r00ta merged commit 5c9c4ad into 5733d9e2be6485d52ffa08870cabdee0:main Jan 20, 2023
r00ta added a commit to r00ta/sandbox that referenced this pull request Jan 20, 2023
r00ta added a commit that referenced this pull request Jan 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants