Bug-fix: Handle changes to OpenAPI models when pydantic v2 is installed #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjwbbc
force-pushed
the
bug-fix/pydantic_v2
branch
from
c5e0695
to
4ebaa7b
Compare
rjb1000
approved these changes
Dec 20, 2023
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where the AS would abort when it was configured because the object to JSON string conversion function no longer takes json.dumps() keyword arguments in pydantic v2.
The fix will detect if the pydantic v2
model_dump()method is available on the object and adapt the way in which it generates the JSON string appropriately.This also fixes another issue with pydantic v2 now using a
Urlclass to model URL properties instead of a string.Closes #81