feat(core)!: Introduce two new CRDs and update existing ones #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
seungsoo-lee
approved these changes
Jan 12, 2024
api/v1/nimbuspolicy_types.go
Outdated
| type NimbusFromSource struct { | ||
| Path string `json:"path,omitempty"` | ||
| RuleAction string `json:"action"` | ||
| Mode string `json:"mode,omitempty"` |
There was a problem hiding this comment.
Please add some description for each field
| FromSource []SyscallFromSource `json:"fromSource,omitempty"` | ||
| } | ||
| // Mode defines the enforcement behavior of the intent. | ||
| // Defaults to best-effort. |
There was a problem hiding this comment.
Please mention "strict" here, and also what it means
There was a problem hiding this comment.
Please mention "strict" here
We'll be updating our documentation to list all possible field values, so I don't think there's a need to mention strict here.
what it means
Mode defines the enforcement behavior of the intent.
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
This was referenced Jan 13, 2024
|
|
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
This issue has been fixed. |
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #34
Does this PR introduce a breaking change?
Yes.
Checklist
<type>: <description>conventionAdditional information for reviewer
Hold off on merging this PR for now. The CRDs'
statusfield is still under development and need to be finalized before this PR can be integrated.Mention if this PR is part of any design or a continuation of previous PRs