Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel filter not subtracted from characters remaining. #103

Closed
Wulfre opened this issue Apr 6, 2016 · 2 comments
Closed

Channel filter not subtracted from characters remaining. #103

Wulfre opened this issue Apr 6, 2016 · 2 comments

Comments

@Wulfre
Copy link

Wulfre commented Apr 6, 2016

When in a tabbed channel, the input field does not account for the channel filter, and therefore using all 140 characters results in the error: '[robin] could not send your message'.
@Wulfre Wulfre changed the title Subtract chat filter from characters remaining Channel filter not subtracted from characters remaining. Apr 6, 2016
@rosslh
Copy link

rosslh commented Apr 6, 2016

Good catch

@dashed
Copy link

dashed commented Apr 6, 2016

We're aware of this; I'm taking a break for abit. Feel to PR to fix this.

@dashed dashed closed this as completed in 7c5e790 Apr 6, 2016
dashed added a commit that referenced this issue Apr 6, 2016
@dashed
Merge pull request #111 from vinnymac/master
3e1dcac 
fix #103 remaining characters now consider channel length
vinnymac added a commit to vinnymac/parrot that referenced this issue Apr 6, 2016
@vinnymac
fix 5a1t#103 more performant time remaining
fe2f262
vinnymac added a commit to vinnymac/parrot that referenced this issue Apr 6, 2016
@vinnymac
fix 5a1t#103 more performant time remaining
eb1e2fd
vinnymac added a commit to vinnymac/parrot that referenced this issue Apr 6, 2016
@vinnymac
fix 5a1t#103 more performant time remaining
7663399
vinnymac added a commit to vinnymac/parrot that referenced this issue Apr 6, 2016
@vinnymac
fix 5a1t#103 more performant time remaining
6a2b4e9
ghost pushed a commit that referenced this issue Apr 6, 2016
@Klynni
Merge pull request #133 from vinnymac/better-time-remaining
5aa8bfd 
fix #103 more performant time remaining
dashed added a commit that referenced this issue Apr 6, 2016
@dashed
Revert "fix #103 more performant time remaining"
b402879 
This reverts commit 6a2b4e9.
vinnymac added a commit to vinnymac/parrot that referenced this issue Apr 6, 2016
@vinnymac
Revert "Revert "fix 5a1t#103 more performant time remaining""
bedcd81 
This reverts commit b402879.
vinnymac added a commit to vinnymac/parrot that referenced this issue Apr 6, 2016
@vinnymac
fix 5a1t#103 added eval to more performant fix for greasemonkey support
7ef59c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dashed @Wulfre @rosslh