[#4] Use calldata instead of memory to optimize gas usage

5afe · Jul 3, 2023 · c389ea8 · c389ea8
1 parent 926191d
commit c389ea8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/contracts/SafeProtocolMediator.sol b/contracts/SafeProtocolMediator.sol
@@ -70,7 +70,7 @@ contract SafeProtocolMediator is ISafeProtocolMediator {
         data = new bytes[](transaction.actions.length);
         uint256 length = transaction.actions.length;
         for (uint256 i = 0; i < length; ++i) {
-            SafeProtocolAction memory safeProtocolAction = transaction.actions[i];
+            SafeProtocolAction calldata safeProtocolAction = transaction.actions[i];
             (bool isActionSuccessful, bytes memory resultData) = ISafe(safe).execTransactionFromModuleReturnData(
                 safeProtocolAction.to,
                 safeProtocolAction.value,
@@ -101,7 +101,7 @@ contract SafeProtocolMediator is ISafeProtocolMediator {
         address safe,
         SafeRootAccess calldata rootAccess
     ) external override onlyEnabledModule(safe) returns (bytes memory data) {
-        SafeProtocolAction memory safeProtocolAction = rootAccess.action;
+        SafeProtocolAction calldata safeProtocolAction = rootAccess.action;
 
         if (!ISafeProtocolModule(msg.sender).requiresRootAccess() || !enabledModules[safe][msg.sender].rootAddressGranted) {
             revert ModuleRequiresRootAccess(msg.sender);