Implement a mediator for modules only #4

rmeissner · 2023-06-16T08:13:12Z

Implements Safe Protocol Mediator interface
Can be connected to a Safe contract (.e.g set protocol as a module)
Accounts can add modules
- Track if module requires root access (can perform delegate calls)
- Root access MUST require user confirmation on enabling the module

…nction, rename struct MoudleAccessInfo

…d execution

…root tx

…module

…eate tx variables

rmeissner added this to the v0.1.0 milestone Jun 16, 2023

rmeissner changed the title ~~Implement PoC of Mediator for modules~~ Implement a mediator for modules only Jun 16, 2023

akshay-ap added a commit that referenced this issue Jun 20, 2023

[#4] Create mediator interface

bf7c628

akshay-ap added a commit that referenced this issue Jun 20, 2023

[#4] Create SafeProtcolMediator contract

31772a6

akshay-ap added a commit that referenced this issue Jun 20, 2023

[#4] Create an ownable mediator contract, define mediator interface

22338ec

akshay-ap added a commit that referenced this issue Jun 20, 2023

[#4] Setup TestExecutor contract

81efd68

akshay-ap added a commit that referenced this issue Jun 20, 2023

[#4] Format *.sol files

11fe5d3

akshay-ap added a commit that referenced this issue Jun 20, 2023

[#4] Add test modules

96f2067

akshay-ap added a commit that referenced this issue Jun 20, 2023

[#4] WIP: Add events, errors, logic in protocol mediator

6546e17

akshay-ap added a commit that referenced this issue Jun 21, 2023

[#4] Format *.sol files

4a1dc84

akshay-ap mentioned this issue Jun 21, 2023

Module mediator #12

Merged

9 tasks

akshay-ap added a commit that referenced this issue Jun 21, 2023

[#4] Fix imports

59c3ae8

akshay-ap added a commit that referenced this issue Jun 23, 2023

[#4] Add functions to enable/disable modules from mediator

4aa7ca5

akshay-ap added a commit that referenced this issue Jun 23, 2023

[#1,#4] Add .solcover.js file

4c35d13

akshay-ap added a commit that referenced this issue Jun 23, 2023

[#4] Add events for enable/disable modules, add getModuleInfo(...) fu…

e026c30

…nction, rename struct MoudleAccessInfo

akshay-ap added a commit that referenced this issue Jun 23, 2023

[#4] Add tests for enable/disable module

b83c7e0

akshay-ap added a commit that referenced this issue Jun 23, 2023

[#4] Run yarn fmt:sol

d76e769

akshay-ap added a commit that referenced this issue Jun 23, 2023

[#4] Fix lint warnings related to imports

bb6607a

akshay-ap added a commit that referenced this issue Jun 23, 2023

[#4] Remove use of nonce from Protocol mediator for module

1d7ae7f

akshay-ap added a commit that referenced this issue Jun 26, 2023

[#4] Add bignumber.js as dependency

a6400a0

akshay-ap added a commit that referenced this issue Jun 26, 2023

[#4] Update function arguments for test module(s)

728d538

akshay-ap added a commit that referenced this issue Jun 26, 2023

[#4] Allow test executor to receive ethers

c3581dc

akshay-ap added a commit that referenced this issue Jun 26, 2023

[#4] Add test for executing transaction from a mediator

0a897f5

akshay-ap added a commit that referenced this issue Jun 26, 2023

[#4] Add event for failed non-root execution, add test case for faile…

abc7d00

…d execution

akshay-ap added a commit that referenced this issue Jun 26, 2023

[#4] Add test case for protocol mediator, run yarn fmt:ts

7c5a350

rmeissner assigned akshay-ap Jun 26, 2023

akshay-ap added a commit that referenced this issue Jun 26, 2023

[#4] Add test delegate contract, add test case for root access action

97fea95

akshay-ap added a commit that referenced this issue Jun 26, 2023

[#4] Add test case: Non-enabled module should not be able to execute …

eec4486

…root tx

akshay-ap added a commit that referenced this issue Jun 26, 2023

[#4] Use execTransactionFromModuleReturnData

4e0a1aa

akshay-ap added a commit that referenced this issue Jun 26, 2023

[#4] Add test case for failed root access action execution

5322a76

akshay-ap added a commit that referenced this issue Jun 29, 2023

[#4] Remove TODOs

c5ff7e9

akshay-ap added a commit that referenced this issue Jun 29, 2023

[#4] Rename test fallback receiver contracts

eb32632

akshay-ap added a commit that referenced this issue Jun 29, 2023

[#4] Remove 'enabled' flag from ModuleAccessInfo

cc21da7

akshay-ap added a commit that referenced this issue Jun 29, 2023

[#4] Rename variable enabledComponents to enabledModules

941f844

akshay-ap added a commit that referenced this issue Jun 29, 2023

[#4, #16] Remove todo related to checking interface id when enabling …

65a45ea

…module

akshay-ap added a commit that referenced this issue Jun 30, 2023

[#4] Remove unnecessary conversion to address, update comment

76e6833

akshay-ap added a commit that referenced this issue Jun 30, 2023

[#4] Create variable for addresses used more than once in tests

6b4efde

akshay-ap added a commit that referenced this issue Jun 30, 2023

[#4] Create constant.ts file, add new line in a test

69613fc

akshay-ap added a commit that referenced this issue Jun 30, 2023

[#4] Fix lint issue

a525b1a

akshay-ap added a commit that referenced this issue Jun 30, 2023

[#4] Index event params: Safe address and module

9578e58

akshay-ap added a commit that referenced this issue Jul 2, 2023

[#4] Add flag for gas reporting

ba38ad0

akshay-ap added a commit that referenced this issue Jul 2, 2023

[#4] Set signers in fixture

c9346bb

akshay-ap added a commit that referenced this issue Jul 2, 2023

[#4] Set signers in before function rather than in fixture

c230fc6

akshay-ap added a commit that referenced this issue Jul 2, 2023

[#4] Set signers in before function rather than in fixture

040b4ad

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4] Optimize gas usage for enableModule function

54d6117

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4] Optimize gas usage for disableModule function

3a4a3e2

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#1 #4] Add yarn fmt command

0b78794

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4] Create builder.ts, dataTypes.ts, and use builder functions to cr…

d49a836

…eate tx variables

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4] Create builder.ts, dataTypes.ts, and use builder functions to cr…

8f55555

…eate tx variables

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4 #13] Update natspec docstring in ISafeProtocolMediator interface

ba6d113

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4 #13] Update natspec docstring in ISafeProtocolMediator interface

d9af1ab

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4 #13] Update natspec docstring in ISafeProtocolMediator interface

ccf7c6e

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4] Update test descriptions

b9734c1

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4] Update notice for executeTransaction

67855ba

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4] Cache array size to save gas usage

e030e3c

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4] Optimize gas usage by removing conversions

926191d

akshay-ap added the enhancement New feature or request label Jul 3, 2023

akshay-ap added a commit that referenced this issue Jul 3, 2023

[#4] Use calldata instead of memory to optimize gas usage

c389ea8

akshay-ap added a commit that referenced this issue Jul 4, 2023

[#4] Fix contract name to TestFallbackReceiver in .solcover.js

7172d5d

akshay-ap closed this as completed in #12 Jul 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement a mediator for modules only #4

Implement a mediator for modules only #4

rmeissner commented Jun 16, 2023 •

edited by akshay-ap

Implement a mediator for modules only #4

Implement a mediator for modules only #4

Comments

rmeissner commented Jun 16, 2023 • edited by akshay-ap

rmeissner commented Jun 16, 2023 •

edited by akshay-ap