Disable spellchecker in eth address field - re #2257 #2557
Conversation
|
CLA Assistant Lite: I have read the CLA Document and I hereby sign the CLA You can retrigger the CLA Action by commenting recheckcla in this Pull Request |
|
I have read the CLA Document and I hereby sign the CLA |
|
For sure! Am loving this project! |
|
recheckcla |
| @@ -203,7 +203,7 @@ const SafeOwnersForm = (props): React.ReactElement => { | |||
| testId={`create-safe-owner-name-field-${index}`} | |||
| /> | |||
| </Col> | |||
| <Col className={classes.ownerAddress} xs={7}> | |||
| <Col className={classes.ownerAddress} spellcheck="false" xs={7}> | |||
There was a problem hiding this comment.
Col is a div element, it's not an input
You should place the attribute to the generic AddressInput component
There was a problem hiding this comment.
Totally, you're so right! Thank you @mikheevm
|
@gabriel-horvat if you’d like to work on a complete new feature, #970 might be interesting. Otherwise, yeah, whatever strikes your fancy, we’ll be happy to help. |
|
Thank you @katspaugh, will take a look at #970 later today |
| type="text" | ||
| autoCorrect={false} | ||
| spellCheck={false} |
There was a problem hiding this comment.
You have already set the spellCheck attribute on the generic AddressInput component, you do not need to repeat it here. If you want to add a different attribute (autoCorrect), please add it to the generic component
Also, please pay attention to the types: in the component, you pass false as a string but here you pass it as a boolean
|
@francovenica honestly I have no idea, it looks like it cannot get some environment variables because the PR is from a forked repository. I would say this PR is fine to be merged without QA approval because it doesn't touch the logic at all |
|
@mikheevm Ok, if it looks fine in the code for you then let's merge. I'll check it once is on dev |
What it solves
Browser was underlining the input text with a red wavy line. But an address isn't supposed to be spell-checked.
Environment
Browser: Chrome
How this PR fixes it
Disabled HTML spellcheck for safe address input element.
Screenshots
Unfixed:
Fixed: