Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Disable the spellchecker in the address field #2257

Closed
katspaugh opened this issue May 5, 2021 · 4 comments · Fixed by #2557
Closed

Disable the spellchecker in the address field #2257

katspaugh opened this issue May 5, 2021 · 4 comments · Fixed by #2557
Labels
effort-tiny Super-easy issues Enhancement ✨ Minor Improvement / changes to existing functionality Minor Needs to be fixed within the next 1-3 public releases.
Milestone
3.11.0

Comments

@katspaugh
Copy link
Member

Title/Description

The browser is underlining the input text with a red wavy line. An address isn't supposed to be spell-checked.

Environment

  • Browser: Chrome

Steps to reproduce

  1. Create or load a safe.
  2. In the address field, enter some address or domain

Expected result

It shouldn't be highlighted as an error.

Obtained result

Spellchecker highlights the address as an error.

Screenshots

Screenshot 2021-05-05 at 18 03 22

How to fix

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck
@katspaugh katspaugh added Enhancement ✨ Minor Improvement / changes to existing functionality Minor Needs to be fixed within the next 1-3 public releases. labels May 5, 2021
@katspaugh katspaugh added the effort-tiny Super-easy issues label Jun 8, 2021
@gabriel-horvat
Copy link
Contributor

Is this a good first issue to familiarize myself with the project?

@mmv08
Copy link
Member

mmv08 commented Jul 14, 2021

Is this a good first issue to familiarize myself with the project?

Yes :)

@gabriel-horvat
Copy link
Contributor

Ok, great! Will do it then :)

@gabriel-horvat
Copy link
Contributor

Just submitted the PR :)

@dasanra dasanra linked a pull request Jul 20, 2021 that will close this issue
Disable spellchecker in eth address field - re #2257 #2557
Merged
@dasanra dasanra added this to New issues in Gnosis Safe React (Archived) via automation Jul 20, 2021
@dasanra dasanra moved this from New issues to Code review and dev test in Gnosis Safe React (Archived) Jul 20, 2021
@dasanra dasanra moved this from Code review and dev test to Ready for QA in Gnosis Safe React (Archived) Jul 20, 2021
@francovenica francovenica moved this from Ready for QA to QA in progress in Gnosis Safe React (Archived) Jul 20, 2021
@francovenica francovenica moved this from QA in progress to QA done in Gnosis Safe React (Archived) Jul 21, 2021
Gnosis Safe React (Archived) automation moved this from QA done to Closed Jul 21, 2021
dasanra pushed a commit that referenced this issue Jul 21, 2021
@gabriel-horvat
Disable spellchecker in eth address field - re #2257 (#2557)
fd22f6e
@dasanra dasanra added this to the 3.11.0 milestone Jul 21, 2021
@dasanra dasanra mentioned this issue Jul 28, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort-tiny Super-easy issues Enhancement ✨ Minor Improvement / changes to existing functionality Minor Needs to be fixed within the next 1-3 public releases.
Projects
None yet
Milestone
3.11.0
Development

Successfully merging a pull request may close this issue.

Disable spellchecker in eth address field - re #2257 gabriel-horvat/safe-react
4 participants
@katspaugh @mmv08 @dasanra @gabriel-horvat