This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Created auxiliary functioon to check if a module is enabled #2570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
dasanra
approved these changes
Jul 22, 2021
mmv08
suggested changes
Jul 22, 2021
src/routes/safe/components/Settings/SpendingLimit/NewLimitModal/Review.tsx
Outdated
Show resolved
Hide resolved
|
Tried the issue of not being able to create a new allowance for an user once the module was previously enabled. Looks good to me |
mmv08
reviewed
Jul 26, 2021
src/routes/safe/components/Settings/SpendingLimit/NewLimitModal/Review.tsx
Outdated
Show resolved
Hide resolved
mmv08
reviewed
Jul 27, 2021
src/logic/safe/utils/modules.ts
Outdated
| @@ -64,3 +65,7 @@ export const enableModuleTx = ({ | |||
| notifiedTransaction: TX_NOTIFICATION_TYPES.SETTINGS_CHANGE_TX, | |||
| } | |||
| } | |||
|
|
|||
| export const isModuleEnabled = (modules: string[] | undefined | null, moduleAddress: string): boolean => { | |||
There was a problem hiding this comment.
why the type here for modules is so broad? I believe this function works correctly only if string[] is passed
added 2 commits
July 28, 2021 10:42
dasanra
deleted the
fix/2549-creating-new-spending-limit-tries-to-add-module-again
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Resolves #2549
How this PR fixes it
We check for the module to be available in stead of checking that there is any spending limit
How to test it
It shouldn't create the transaction to enable the spending limit module