Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

Spending limit - Creating a spending limit is trying to add the module again #2549

Closed
francovenica opened this issue Jul 16, 2021 · 1 comment · Fixed by #2570
Closed

Spending limit - Creating a spending limit is trying to add the module again #2549

francovenica opened this issue Jul 16, 2021 · 1 comment · Fixed by #2570
Assignees
Labels
Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases.
Milestone

Comments

@francovenica
Copy link
Contributor

francovenica commented Jul 16, 2021

Issue:
After the Spending limit module is enabled, any future spending limit creation should just create the "Allowance" for the owner to use tokens, but the tx is trying to enable the module again

Steps:
Create a new safe with a "2 owners" policy
Create a spending limit with ETH
Check that the owner is listed in the spending limit table
Delete that spending limit
Try to create another spending limit for any owner

Expected result:
The app should check whether the spending limit module is enabled

  • If yes, just the set allowance, no need to enable the module again.
  • if no, the module first needs to be enabled.

Current result:
The tx has the action to enable the module again

Check this safe, that has the tx in Queue where is trying to enable the module again, then check also the "Advanced" settings, where the module for spending limit can be seen already active:
https://pr2535--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x2733739C73DaFe449BBd4d962CbE270221A85944/transactions

@francovenica francovenica added the Bug 🐛 Something isn't working label Jul 16, 2021
@francovenica francovenica added this to New issues in Gnosis Safe React (Archived) via automation Jul 16, 2021
@tschubotz tschubotz added the Minor Needs to be fixed within the next 1-3 public releases. label Jul 16, 2021
@tschubotz tschubotz moved this from New issues to Bugs in Gnosis Safe React (Archived) Jul 16, 2021
@francovenica
Copy link
Contributor Author

I've checked and this issue is actually in prod v3.9.0 so is not a blocker for the release.

@juampibermani juampibermani self-assigned this Jul 16, 2021
@juampibermani juampibermani moved this from Bugs to Development in progress in Gnosis Safe React (Archived) Jul 16, 2021
@juampibermani juampibermani moved this from Development in progress to Code review and dev test in Gnosis Safe React (Archived) Jul 19, 2021
@dasanra dasanra added this to the 3.11.0 milestone Jul 21, 2021
@dasanra dasanra moved this from Code review and dev test to Ready for QA in Gnosis Safe React (Archived) Jul 22, 2021
@francovenica francovenica moved this from Ready for QA to QA in progress in Gnosis Safe React (Archived) Jul 22, 2021
@francovenica francovenica moved this from QA in progress to QA done in Gnosis Safe React (Archived) Jul 23, 2021
Gnosis Safe React (Archived) automation moved this from QA done to Closed Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants