Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

feat: Sidebar Redesign #3776

Closed
wants to merge 6 commits into from
Closed

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Apr 8, 2022

REPLACED BY #3778

What it solves

Resolves #3504

How this PR fixes it

  • Adjusts the design according to Figma.
  • Adds a Home link to the navigation
  • Adds Queue, History links to the navigation

How to test it

  1. Open the Safe app
  2. Observe that there is a Home link
  3. Observe that there are links to the Transaction Queue and History
  4. Observe that the Sidebar looks according to the design

Open questions

Should some of these changes be done in the safe-react-components package

Screenshots

Screenshot 2022-04-08 at 16 49 02

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

CLA Assistant Lite All Contributors have signed the CLA.

@usame-algan usame-algan changed the base branch from dev to epic-dashboard April 8, 2022 09:25
@katspaugh
Copy link
Member

katspaugh commented Apr 8, 2022

  1. Menu font seems a bit too thick compared to Figma
  2. Accordion arrows on Figma are black
  3. No arrow icon on the New Transaction button
  4. Copy/share icons should be green inside the gray buttons
  5. I think dividers are thinner in the new design

Please also check the spacing between elements. E.g. the gap between copy/share buttons and Total Balance.

@iamacook
Copy link
Member

iamacook commented Apr 8, 2022

Why no semicircle around arrow that opens the sidebar ser?

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@usame-algan
Copy link
Member Author

usame-algan commented Apr 8, 2022

Menu font seems a bit too thick compared to Figma

I think this has to do with cross-browser font-rendering. We might be able to improve it with font-smoothing (Although I haven't noticed a difference on my end) We already have it in place.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good dude. I think you can just abstract some of the values into theme variables.

background-color: ${background};

& .icon-color {
fill: #008c73;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We export this colour as secondary.

}

&:hover {
background-color: #effaf8;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is probably worthwhile adding this to the variables file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized we already have it as primaryLite but I also added primaryGreen200 because of different naming in our style guide. Removed primaryGreen200 again and use primaryLite now everywhere. We can tackle possible renaming of this in a later task.

background-color: ${background};

& .icon-color {
fill: #008c73;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secondary

}

&:hover {
background-color: #effaf8;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can import this if you add it to the variables file.

transition: background-color 0.2s ease-in-out;

& .icon-color {
fill: #008c73;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

secondary

}

& .MuiListItemText-root span {
line-height: 1;
}

&.MuiListItem-button:hover {
background-color: #f6f7f8;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're using this colour often as well. I'd export it from the variables file too.

@iamacook
Copy link
Member

iamacook commented Apr 8, 2022

  • The arrow icon when the 'non-Safe' sidebar is shown is misplaced:

image

  • The tooltips only display if you hover on the icon. I think you should bring them up a level to display when hovering over the button itself. Here I'm hovering on the button but see no tooltip:

image

  • I feel like the semicircle needs to be shift left a little bit more:

image

  • I think the 'New transaction' button shouldn't have bold text

image

@usame-algan
Copy link
Member Author

I think the 'New transaction' button shouldn't have bold text

Agreed, I changed the style to be like other buttons in the app (16px font-size, not bold)

@usame-algan usame-algan changed the base branch from epic-dashboard to dev April 11, 2022 08:38
@usame-algan usame-algan changed the base branch from dev to epic-dashboard April 11, 2022 08:38
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2022
@katspaugh katspaugh deleted the dashboard-sidebar-redesign branch July 19, 2022 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New sidebar design
3 participants