Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

feat: Sidebar redesign #3778

Merged
merged 11 commits into from Apr 12, 2022
Merged

feat: Sidebar redesign #3778

merged 11 commits into from Apr 12, 2022

Conversation

usame-algan
Copy link
Member

@usame-algan usame-algan commented Apr 11, 2022

What it solves

Resolves #3504

How this PR fixes it

  • Adjusts the design according to Figma.
  • Adds Queue, History links to the navigation

How to test it

  1. Open the Safe app
  2. Observe that there are links to the Transaction Queue and History
  3. Observe that the Sidebar looks according to the design

Screenshots

Screenshot 2022-04-11 at 11 07 16

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Apr 11, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@coveralls
Copy link

coveralls commented Apr 11, 2022

Pull Request Test Coverage Report for Build 2154519931

  • 0 of 16 (0.0%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 35.583%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/AppLayout/Sidebar/useSidebarItems.tsx 0 1 0.0%
src/components/List/ListIcon.tsx 0 2 0.0%
src/components/List/index.tsx 0 4 0.0%
src/components/AppLayout/Sidebar/SafeHeader/index.tsx 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/AppLayout/Sidebar/SafeHeader/index.tsx 1 0%
src/components/AppLayout/Sidebar/useSidebarItems.tsx 1 0%
src/components/List/index.tsx 1 0%
Totals Coverage Status
Change from base Build 2147308671: -0.03%
Covered Lines: 3548
Relevant Lines: 9017

💛 - Coveralls

@github-actions
Copy link

Deployment links

🟠 Rinkeby Mainnet 🟣 Polygon 🟡 BSC Arbitrum 🟢 Gnosis Chain

Copy link
Member

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Copy link
Member

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Usame! Left some comments

src/components/AppLayout/Sidebar/SafeHeader/index.tsx Outdated Show resolved Hide resolved
src/components/AppLayout/Sidebar/SafeHeader/index.tsx Outdated Show resolved Hide resolved
src/components/List/index.tsx Outdated Show resolved Hide resolved
src/components/List/index.tsx Outdated Show resolved Hide resolved
src/components/List/index.tsx Outdated Show resolved Hide resolved
src/components/List/index.tsx Outdated Show resolved Hide resolved
@DiogoSoaress
Copy link
Member

This extra "stem" is also undesired

Screen Shot 2022-04-11 at 12 22 29

Copy link
Member

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments 👍

@francovenica
Copy link
Contributor

francovenica commented Apr 12, 2022

Note: I'll assume that the list of safes that is in the Figma design is out of the scope of this ticket, since I haven't seen any change in that safe list
image

@francovenica
Copy link
Contributor

The colors, fonts, spacing, elements, etc looks fine.
The only thing we could discuss is the length of the menu (as it was discussed in a daily earlier)
The menu is kinda small when the safe is in read only mode.
Note: I don't expect a fix from this, just an agreement if we should try to make it longer o leave it the way it is.

image

If the length of the menu is not considered an issue then I'd pass the ticket to QA done.

@francovenica
Copy link
Contributor

Confirmed that the list of safes is for another ticket, so out of the scope of this one.

Regarding the length of the menu, it was decided that we will remove the "Read Only" label and make the "New Transaction" button to change the text to "Read Only" when the conditions are met (Not connected, not owner of the safe)

@francovenica
Copy link
Contributor

It looks good to me.

The button shows Read Only when the user is not connected or is not owner, and reverts to New tx when the conditions are met.

@usame-algan usame-algan merged commit 4ee066d into dev Apr 12, 2022
@usame-algan usame-algan deleted the sidebar-redesign branch April 12, 2022 12:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New sidebar design
5 participants