Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta feedback cleanup #52

Merged
merged 5 commits into from
Feb 9, 2017
Merged

Beta feedback cleanup #52

merged 5 commits into from
Feb 9, 2017

Conversation

mccarron
Copy link
Collaborator

@mccarron mccarron commented Feb 9, 2017

Cleanup for Bugs in #50

  • Added "What's important to you?" header on issues list
  • On the issue page before location is set, don't show the "Call your representatives" header.
  • Left aligning the issue title
  • The background color for the reps under the choose a rep header was dark, used the same from the header

Outstanding suggestion

Consider using the ghost text from the location box on the web in place of "Set location"

Didn't do this, wasn't completely clear. Tried: Enter location or zip code but wasn't in love with it. RE

notAButton.setTitleColor(blueTextColor, for: .normal)
notAButton.backgroundColor = UIColor(colorLiteralRed:0.96, green:0.96, blue:0.96, alpha:1.0)
notAButton.borderWidth = 1
notAButton.borderColor = UIColor(colorLiteralRed:0.88, green:0.88, blue:0.88, alpha:1.0)
Copy link
Collaborator

@subdigital subdigital Feb 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to change this, but could be simplified as UIColor(white: 0.88, alpha: 1.0)

@subdigital subdigital merged commit a780f74 into master Feb 9, 2017
@subdigital subdigital deleted the beta-feedback-cleanup branch February 9, 2017 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants