-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magic Item Definitions #115
Comments
Not that I know of, but we'd happily like it if we don't already have it.
…On Mon, Nov 25, 2019 at 12:31 PM Andrew Hansen ***@***.***> wrote:
I saw [this other SRD repo[(
https://github.com/BTMorton/dnd-5e-srd/blob/master/json/10%20magic%20items.json)
has a json list of magic items included in the SRD.
Has there been any investigation to adding these to 5e-database?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#115>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWKWURMVLZOMMM6PQBHOLQVQYZJANCNFSM4JROLWOQ>
.
|
I was thinking about the schema and came up with this. I'd be happy to discuss it further.
There's also the question of how to handle weapons and armor since they have a lot more properties but it's overlapping with the base weapon/armor. |
Would Honestly, if you really want, we can start with just:
And only add fields that aren't immediately encapsulated there? I can see @ogregoire Any thoughts on this? |
Yes, I've been thinking the same: start simple then find structures where they are, or when needed. |
Actually yes, |
I would keep For
These are also taken from DnDBeyond. |
Actually, I would really keep it as simple as @bagelbits mentioned.
Why so simple? Because of the one reason I never worked on them: they're extremely complex. When you think about adding
|
Yeah, you're right. We would need separate entries for all those items but not right now. What about the magical item categories, like "Wondrous Item". Do you think we could include it? EDIT: typo |
We already have the |
Yup! I agree with @ogregoire on all of this. It's best to keep it really simple on the first version. And after we get it all in, we can start on separate efforts to extract patterns. As I lovingly tell other engineers at work, K.I.S.S.: Keep It Simple, Silly. I would adjust the proposed schema to:
As an aside, I noticed in
So I'm going to cut a separate issue to get that updated. |
I think we're all on the same page for the V1 of this. @vpeter1119, if you still feel up to pushing forward with a PR for this, feel free to. :D |
Okay, I've setup a WIP PR for this. I'm slowly working my way through the SRD to get this all added. However, I'd love feedback for where it is so far. |
I saw this other SRD repo has a json list of magic items included in the SRD.
Has there been any investigation to adding these to 5e-database?
The text was updated successfully, but these errors were encountered: