Skip to content
This repository has been archived by the owner on Jun 14, 2020. It is now read-only.

Fixed bug #22, the upsert request script in plainless was flawed. #24

Merged
merged 1 commit into from
May 3, 2018

Conversation

5hirish
Copy link
Owner

@5hirish 5hirish commented May 3, 2018

Fixed fallback when default model not found

Description

Addresses the Issue #22

Types of change

  1. Fixed the Upsert GET request, where the painless script had a typo of a comma.
  2. Added fallback logic if the language model not found.

Checklist

  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

Fixed fallback when default model not found
@5hirish 5hirish added bug : () elasticsearch Issues related to Elasticsearch labels May 3, 2018
@5hirish 5hirish self-assigned this May 3, 2018
@codecov
Copy link

codecov bot commented May 3, 2018

Codecov Report

Merging #24 into master will decrease coverage by 0.32%.
The diff coverage is 5.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   40.85%   40.53%   -0.33%     
==========================================
  Files          26       26              
  Lines        1383     1394      +11     
  Branches      194      195       +1     
==========================================
  Hits          565      565              
- Misses        788      799      +11     
  Partials       30       30
Impacted Files Coverage Δ
qas/adam.py 0% <0%> (ø) ⬆️
qas/esstore/es_operate.py 34.95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a004a11...2f13cab. Read the comment docs.

@5hirish 5hirish merged commit 598ffd8 into master May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug : () elasticsearch Issues related to Elasticsearch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant