Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce and run pre-commit #92

Closed
wants to merge 2 commits into from
Closed

Introduce and run pre-commit #92

wants to merge 2 commits into from

Conversation

Mojken
Copy link
Contributor

@Mojken Mojken commented Mar 30, 2022

No description provided.

Copy link
Contributor

@Swamii Swamii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

.pre-commit-config.yaml Outdated Show resolved Hide resolved
.pre-commit-config.yaml Outdated Show resolved Hide resolved
@Mojken
Copy link
Contributor Author

Mojken commented Mar 30, 2022

This is what flake8 complained about btw:

runtests.py:15:20: C408 Unnecessary dict call - rewrite as a literal.
DEFAULT_SETTINGS = dict(
                   ^
djedi/__init__.py:36:14: C408 Unnecessary dict call - rewrite as a literal.
    config = dict(
             ^
djedi/admin/__init__.py:20:17: C408 Unnecessary dict call - rewrite as a literal.
                dict(
                ^
docs/conf.py:185:5: E265 block comment should start with '# '
    #'papersize': 'letterpaper',
    ^
docs/conf.py:187:5: E265 block comment should start with '# '
    #'pointsize': '10pt',
    ^
docs/conf.py:189:5: E265 block comment should start with '# '
    #'preamble': '',
    ^
djedi/compat.py:99:1: E402 module level import not at top of file
from collections import namedtuple
^
djedi/compat.py:100:1: E402 module level import not at top of file
from inspect import getfullargspec
^

Co-authored-by: Akseli Nelander <Anelander@gmail.com>
@Mojken
Copy link
Contributor Author

Mojken commented Mar 31, 2022

Closing in favor of #93

@Mojken Mojken closed this Mar 31, 2022
@Mojken Mojken deleted the pre-commit branch March 31, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants