Add pre-commit #93
Merged
Add pre-commit #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's been replaced by Github Actions
--no-binary breaks some django versions because all translation files are skipped
The issue is that coverage.py doesn't support 3.6 anymore (EOL 2021-12-23), so we couldn't generate coverage reports for it.
Instead of for each matrix step
There are now no compat issues. With some work, the compat files can be removed completely
Since we don't generate the lcov report more than once now, we can support 3.6 again!
Swamii
reviewed
Mar 31, 2022
Broken up as a separate commit before running for easier resets
lundberg
reviewed
Mar 31, 2022
it's not 3.6+ instead of 3.7+
lundberg
reviewed
Mar 31, 2022
lundberg
approved these changes
Mar 31, 2022
Co-authored-by: Akseli Nelander <Anelander@gmail.com>
Merge CI into pre-commit branch
|
Is everyone ok with squashing this (to make merge:ing in Beshr's stuff relatively painless)? |
Yes, definitely |
Swamii
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.