Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ambient light to avoid exactly black shadow. #7

Merged
merged 7 commits into from
Jan 11, 2021
Merged

Set ambient light to avoid exactly black shadow. #7

merged 7 commits into from
Jan 11, 2021

Commits on Jan 10, 2021

  1. Fix one row of checkerboard being twice as large.

    @fidergo-stephane-gourichon
    fidergo-stephane-gourichon committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    3a934a3 View commit details
    Browse the repository at this point in the history

  2. Don't normalize ray, just copy.

    @fidergo-stephane-gourichon
    fidergo-stephane-gourichon committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    d5a3a08 View commit details
    Browse the repository at this point in the history

  3. Fix bug in checkerboard floor.

    @fidergo-stephane-gourichon
    fidergo-stephane-gourichon committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    495f3ef View commit details
    Browse the repository at this point in the history

  4. Fix bug in the (admitedly fake) shadow. 

    Notice that the variable that was named "shadow_radius2" is actually compared to the square of distances, so I put it at 4 for a non-squared radius of 2, matching the radius of the sphere.
    @fidergo-stephane-gourichon
    fidergo-stephane-gourichon committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    e4fe90b View commit details
    Browse the repository at this point in the history

  5. Merge branches 'fix_checkerboard_row_twice_as_large', 'fix_checkerboa… 

    …rd_skew' and 'fix_shadow'

* fix_checkerboard_row_twice_as_large:
  Don't normalize ray, just copy.
  Fix one row of checkerboard being twice as large.

* fix_checkerboard_skew:
  Fix bug in checkerboard floor.

* fix_shadow:
  Fix bug in the (admitedly fake) shadow.
    @fidergo-stephane-gourichon
    fidergo-stephane-gourichon committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    84ec1d4 View commit details
    Browse the repository at this point in the history

  6. Set ambient light to avoid exactly black shadow. 

    Makes limit between sphere and floor much clearer and cleaner.
    @fidergo-stephane-gourichon
    fidergo-stephane-gourichon committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    7722e05 View commit details
    Browse the repository at this point in the history

  7. Different approach, not truly ambient light (kind of "see-through sph… 

    …ere"), avoids aliasing near the horizon.
    @fidergo-stephane-gourichon
    fidergo-stephane-gourichon committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    9a8e4c2 View commit details
    Browse the repository at this point in the history