The grid menu does not display properly when frozen columns are used with the grid menu

[songjiqiang]

When frozen column and grid menu are used together, the menu will be displayed in the left frozen column panel. This seems not normal. When I look at the source code, I find that it is caused by the following code logic
I only set frozenColumn to 0 because I only need to freeze the checkbox column

[ghiscoding]

Does it work if you change the source code to ... >= 0 ?

This might give issues on regular grid though (when not using frozenColumn), I'm not sure what is the default of the grid option frozenColumn, we have to check that too... EDIT: the default is -1 so it should be ok to change to >= 0 but I'd like to have confirmation that it works.

[songjiqiang]

The default value of frozenColumn is -1. After I changed the source code in this way, the test was fine. Here is my unit test

[ghiscoding]

Have you tested with a regular grid (without any frozen)?

[songjiqiang]

Yes, I didn't set any frozen columns and normal grids work fine. Here are the unit tests I did not set frozen columns

[ghiscoding]

Ok good, I'll do a fix later.. unless you want to create a PR (Pull Request) yourself? That would be nice.

Thanks

[songjiqiang]

Ok, I will not create PR by myself for the time being. I will upgrade it after your official repair. At present, I temporarily solve this problem by changing the source code.
thank you

[songjiqiang]

@ghiscoding If frozenColumn is set to 0, this judgment is problematic.For example, if(0) is actually false, then the judgment logic should be deleted, Please check the screenshot of my question, thank you

[ghiscoding]

oh damn I didn't catch that since you didn't mention it earlier. I'll fix that later today.

[songjiqiang]

Ok, thank you. I took a screenshot of this question in the comments yesterday. Thank you

[ghiscoding]

I raised another PR, removing frozenColumn is not ideal the property might not exist. What is best to use hasOwnProperty('frozenColumn') and that is what I changed in new PR.

[songjiqiang]

OK, you can also solve it in the following way,
I feel that this approach is more rigorous, because it can be controlled to allow only numbers, and other types of values I think are ineffective.
&& $.type(_gridOptions.frozenColumn) === 'number'

[ghiscoding]

I already did another PR #439 and tested it locally

[songjiqiang]

OK，thanks