Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pageup/pagedown/home/end etc during selection #794

Closed
tomqwpl opened this issue Jun 27, 2023 · 2 comments · Fixed by #854
Closed

Allow pageup/pagedown/home/end etc during selection #794

tomqwpl opened this issue Jun 27, 2023 · 2 comments · Fixed by #854
Labels
has PR

Comments

@tomqwpl
Copy link
Contributor

tomqwpl commented Jun 27, 2023

The cell selection model allows for selection of range using keyboard, but only left, right, up, down.
Normal navigation can also be done using page up, down, home end etc.

It would be nice of the same keys could be used during selection too.
@ghiscoding
Copy link
Collaborator

If you want to implement it then Pull Requests are welcome

ghiscoding added a commit that referenced this issue Oct 1, 2023
@ghiscoding
feat: add pageUp/pageDown/home/end to SlickCellSelection, fixes #794
0682eed 
- fixes #794
- adding "pageUp/pageDown/home/end" to SlickCellSelection when using selection with "Shift+{key}"
- add `hasDataView()` and `getViewportRowCount()` methods to SlickGrid and also make `getViewportHeight()` and `getViewportWidth()` as publish methods
- add new `example-spreadsheet-dataview.html` demo to manually test updated Cell Selection feature
@ghiscoding ghiscoding mentioned this issue Oct 1, 2023
Merged
7 tasks
ghiscoding added a commit that referenced this issue Oct 3, 2023
@ghiscoding
feat: add pageUp/pageDown/home/end to SlickCellSelection, fixes #794 (#…
f4956e4 
…854)

* feat: add pageUp/pageDown/home/end to SlickCellSelection, fixes #794
- fixes #794
- adding "pageUp/pageDown/home/end" to SlickCellSelection when using selection with "Shift+{key}"
- add `hasDataView()` and `getViewportRowCount()` methods to SlickGrid and also make `getViewportHeight()` and `getViewportWidth()` as publish methods
- add new `example-spreadsheet-dataview.html` demo to manually test updated Cell Selection feature
@ghiscoding
Copy link
Collaborator

ghiscoding commented Oct 3, 2023 •
edited
Loading

now available in latest version 5.1.0, I tested with these 2 live examples:

  • Excel spreadsheet
  • Excel spreadsheet with DataView (new), this is a new example and is the same as the previous one but with the use of the DataView, I also added it to test it with Pagination since executing a pageDown (or any other selection type) should not overflow its current page when Pagination is used

@ghiscoding ghiscoding mentioned this issue Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add pageUp/pageDown/home/end to SlickCellSelection, fixes #794 6pac/SlickGrid
2 participants
@ghiscoding @tomqwpl