Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell Selection Model plugin allow Mac Command key + arrows to change the selection #100

Merged

Conversation

joaopapereira
Copy link

When using the Control Key + Arrow Key the plugin ensures that there are no changes to the selections ranges.
For Mac the combination Command Key + Arrow Key should have the same behavior.

Add some tests to the plugin to ensure it is working as expected.

@6pac
Copy link
Owner

6pac commented May 1, 2017

This is a great pull request, but I have to ask: Macs have a Control key so why the need to extend to the Command key?

@joaopapereira
Copy link
Author

Hello,
In Macs despite the existence of the control key the functions that typically are associated with it are done using Command key.
Like copy is Command + C
In that if statement we are excluding the handling of Control + Shift + Arrows by the model, in Mac it make sense to exclude Command + Shift + Arrows instead.

@6pac 6pac merged commit f6d7637 into 6pac:master May 1, 2017
@6pac
Copy link
Owner

6pac commented May 1, 2017

Of course. I use a Mac, but work in Windows using VirtualBox. Never occurred to me. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants