fix bug - do not remove last row from cache

[royling]

It seems an obvious boundary check mistake, comparing the 2 condition check in https://github.com/6pac/SlickGrid/blob/2.1/slick.grid.js#L1601-L1610.

[royling]

Hi,

Recently I submitted this PR (mleibman/SlickGrid#1102) to the original repo for fixing a bug in updateRowCount function, but because the repo is not active any more, no response after that.
From other PRs, I get to this alternative repo (thanks for this to keep SlickGrid going on). So I submitted the PR here again, would you please review it?

Let me know if you think this change may have any impact or any reason why it is as is.

Thanks!

[6pac]

thanks royling. I am aware of this patch but I have been insanely busy for a few months. i will assess and apply it soon. It hasn't been high priority because it's been around for a while and doesn't seem to have been flagged before.
however, patches are always appreciated!

[royling]

This issue may not cause a critical problem, so not flagged. Let me elaborate the problem I encountered:

When editing a cell in the last row in the grid, and do something else to trigger grid resize, then the cell cannot be activated any more.

I debugged the whole process and found that it's removing the cache of the last row, then the row will be redrawn, but leaving active cell as is. Then the click event will not be handled.

Hope this clarifies the issue.

[6pac]

thanks, i wish all pull requests were this well put together! The two conditions definitely should match, but after a quick look I would have thought both should be >= rather than both being >
do you have an opinion on that?

[royling]

No, > is right if you see this line - https://github.com/6pac/SlickGrid/blob/2.1/slick.grid.js#L1601
the variable l = length - 1

[6pac]

(long pause due to holiday)
royling, you are of course correct. I've pulled the patch.

thanks again