feat(grouping): add caller/originator to updateGroupBy on Draggable Grouping #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this helps in knowing who caller the update action and user can do certain thing accordingly with this new info
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Dec 8, 2018
- this fix rely on a PR that might not be merged yet, ref 6pac/SlickGrid#303
ghiscoding
changed the title
ghiscoding
added a commit
to ghiscoding/aurelia-slickgrid
that referenced
this pull request
Dec 8, 2018
* feat(grouping): start working on draggable grouping plugin * feat(grouping): finished draggable grouping plugin example * refactor(build): fix tslint warning * refactor(build): fix build warning with missing argument types * refactor(extension): code cleanup with imports and comments * refactor(grouping): add group by select dropdown to example * refactor(grouping): small improvement in clearing select dropdown - this fix rely on a PR that might not be merged yet, ref 6pac/SlickGrid#303
ghiscoding
pushed a commit
to ghiscoding/Angular-Slickgrid
that referenced
this pull request
Dec 10, 2018
- this fix rely on a PR that might not be merged yet, ref 6pac/SlickGrid#303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvement, and help for the first issue I had opened earlier #299.
I want to know who called the update (is it the group sort, add group, remove group, ...) and this PR does exactly that.